From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754719AbbHXOAZ (ORCPT ); Mon, 24 Aug 2015 10:00:25 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:38093 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754632AbbHXOAX (ORCPT ); Mon, 24 Aug 2015 10:00:23 -0400 Date: Mon, 24 Aug 2015 15:00:19 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH 09/18] mfd: cros_ec: spi: Add OF match table Message-ID: <20150824140019.GL3237@x1> References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-10-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440054451-1223-10-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Aug 2015, Javier Martinez Canillas wrote: > The Documentation/devicetree/bindings/mfd/cros-ec.txt DT binding doc lists > "google,cros-ec-spi" as a compatible string but the corresponding driver > does not have an OF match table. Add the table to the driver so the SPI > core can do an OF style match. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/cros_ec_spi.c | 7 +++++++ > 1 file changed, 7 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c > index 16f228dc243f..30a296b4e748 100644 > --- a/drivers/mfd/cros_ec_spi.c > +++ b/drivers/mfd/cros_ec_spi.c > @@ -701,6 +701,12 @@ static int cros_ec_spi_resume(struct device *dev) > static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend, > cros_ec_spi_resume); > > +static const struct of_device_id cros_ec_spi_of_match[] = { > + { .compatible = "google,cros-ec-spi", }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, cros_ec_spi_of_match); > + > static const struct spi_device_id cros_ec_spi_id[] = { > { "cros-ec-spi", 0 }, > { } > @@ -710,6 +716,7 @@ MODULE_DEVICE_TABLE(spi, cros_ec_spi_id); > static struct spi_driver cros_ec_driver_spi = { > .driver = { > .name = "cros-ec-spi", > + .of_match_table = of_match_ptr(cros_ec_spi_of_match), > .owner = THIS_MODULE, > .pm = &cros_ec_spi_pm_ops, > }, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog