From: Lee Jones <lee.jones@linaro.org>
To: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: sameo@linux.intel.com, lars@metafoo.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip
Date: Mon, 24 Aug 2015 15:01:31 +0100 [thread overview]
Message-ID: <20150824140131.GM3237@x1> (raw)
In-Reply-To: <1440066632-5223-1-git-send-email-matt.redfearn@imgtec.com>
On Thu, 20 Aug 2015, Matt Redfearn wrote:
> The mask cache must be initialised in the generic IRQ chip,
> otherwise enabling one channel will actually enable all
> channels when the empty mask cache is written.
>
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
> ---
> drivers/mfd/jz4740-adc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
> index ae2ad8ad0e2f..e8699c0cdae6 100644
> --- a/drivers/mfd/jz4740-adc.c
> +++ b/drivers/mfd/jz4740-adc.c
> @@ -276,7 +276,8 @@ static int jz4740_adc_probe(struct platform_device *pdev)
> ct->chip.irq_unmask = irq_gc_mask_clr_bit;
> ct->chip.irq_ack = irq_gc_ack_set_bit;
>
> - irq_setup_generic_chip(gc, IRQ_MSK(5), 0, 0, IRQ_NOPROBE | IRQ_LEVEL);
> + irq_setup_generic_chip(gc, IRQ_MSK(5), IRQ_GC_INIT_MASK_CACHE, 0,
> + IRQ_NOPROBE | IRQ_LEVEL);
>
> adc->gc = gc;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-08-24 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 10:30 [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip Matt Redfearn
2015-08-24 14:01 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824140131.GM3237@x1 \
--to=lee.jones@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.redfearn@imgtec.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox