* [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip
@ 2015-08-20 10:30 Matt Redfearn
2015-08-24 14:01 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Matt Redfearn @ 2015-08-20 10:30 UTC (permalink / raw)
To: lee.jones, sameo, lars; +Cc: linux-kernel, matt.redfearn
The mask cache must be initialised in the generic IRQ chip,
otherwise enabling one channel will actually enable all
channels when the empty mask cache is written.
Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
---
drivers/mfd/jz4740-adc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
index ae2ad8ad0e2f..e8699c0cdae6 100644
--- a/drivers/mfd/jz4740-adc.c
+++ b/drivers/mfd/jz4740-adc.c
@@ -276,7 +276,8 @@ static int jz4740_adc_probe(struct platform_device *pdev)
ct->chip.irq_unmask = irq_gc_mask_clr_bit;
ct->chip.irq_ack = irq_gc_ack_set_bit;
- irq_setup_generic_chip(gc, IRQ_MSK(5), 0, 0, IRQ_NOPROBE | IRQ_LEVEL);
+ irq_setup_generic_chip(gc, IRQ_MSK(5), IRQ_GC_INIT_MASK_CACHE, 0,
+ IRQ_NOPROBE | IRQ_LEVEL);
adc->gc = gc;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip
2015-08-20 10:30 [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip Matt Redfearn
@ 2015-08-24 14:01 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-08-24 14:01 UTC (permalink / raw)
To: Matt Redfearn; +Cc: sameo, lars, linux-kernel
On Thu, 20 Aug 2015, Matt Redfearn wrote:
> The mask cache must be initialised in the generic IRQ chip,
> otherwise enabling one channel will actually enable all
> channels when the empty mask cache is written.
>
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
> ---
> drivers/mfd/jz4740-adc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
> index ae2ad8ad0e2f..e8699c0cdae6 100644
> --- a/drivers/mfd/jz4740-adc.c
> +++ b/drivers/mfd/jz4740-adc.c
> @@ -276,7 +276,8 @@ static int jz4740_adc_probe(struct platform_device *pdev)
> ct->chip.irq_unmask = irq_gc_mask_clr_bit;
> ct->chip.irq_ack = irq_gc_ack_set_bit;
>
> - irq_setup_generic_chip(gc, IRQ_MSK(5), 0, 0, IRQ_NOPROBE | IRQ_LEVEL);
> + irq_setup_generic_chip(gc, IRQ_MSK(5), IRQ_GC_INIT_MASK_CACHE, 0,
> + IRQ_NOPROBE | IRQ_LEVEL);
>
> adc->gc = gc;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-24 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-20 10:30 [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip Matt Redfearn
2015-08-24 14:01 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox