From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932999AbbHXOBg (ORCPT ); Mon, 24 Aug 2015 10:01:36 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37585 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754099AbbHXOBf (ORCPT ); Mon, 24 Aug 2015 10:01:35 -0400 Date: Mon, 24 Aug 2015 15:01:31 +0100 From: Lee Jones To: Matt Redfearn Cc: sameo@linux.intel.com, lars@metafoo.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip Message-ID: <20150824140131.GM3237@x1> References: <1440066632-5223-1-git-send-email-matt.redfearn@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440066632-5223-1-git-send-email-matt.redfearn@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Aug 2015, Matt Redfearn wrote: > The mask cache must be initialised in the generic IRQ chip, > otherwise enabling one channel will actually enable all > channels when the empty mask cache is written. > > Signed-off-by: Matt Redfearn > --- > drivers/mfd/jz4740-adc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c > index ae2ad8ad0e2f..e8699c0cdae6 100644 > --- a/drivers/mfd/jz4740-adc.c > +++ b/drivers/mfd/jz4740-adc.c > @@ -276,7 +276,8 @@ static int jz4740_adc_probe(struct platform_device *pdev) > ct->chip.irq_unmask = irq_gc_mask_clr_bit; > ct->chip.irq_ack = irq_gc_ack_set_bit; > > - irq_setup_generic_chip(gc, IRQ_MSK(5), 0, 0, IRQ_NOPROBE | IRQ_LEVEL); > + irq_setup_generic_chip(gc, IRQ_MSK(5), IRQ_GC_INIT_MASK_CACHE, 0, > + IRQ_NOPROBE | IRQ_LEVEL); > > adc->gc = gc; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog