Re: [PATCH] nfit, nd_blk: BLK status register is only 32 bits

Ross Zwisler
2015-08-24T17:41:26Z

On Mon, Aug 24, 2015 at 01:02:17PM -0400, Jeff Moyer wrote:
> Ross Zwisler <ross.zwisler@linux.intel.com> writes:
>
> > Only read 32 bits for the BLK status register in read_blk_stat().
> >
> > The format and size of this register is defined in the
> > "NVDIMM Driver Writer's guide":
> >
> > http://pmem.io/documents/NVDIMM_Driver_Writers_Guide.pdf
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > Reported-by: Nicholas Moulin <nicholas.w.moulin@linux.intel.com>
>
> Looks fine,
>
> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
>
> However, now that you've drawn attention to that code, I'll note that
> there is no checking of the pending or retry bits. In fact,
> ACPI_NFIT_CONTROL_BUFFERED isn't even checked upon loading the tables.
> Is this on a todo list somewhere?

Yep, you're right, we do need to add support for each of these. I'm planning
on doing it unless someone else gets to it first.