From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: Aparna Karuthodi <kdasaparna@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
noralf@tronnes.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: Made into two lines
Date: Mon, 24 Aug 2015 22:33:56 +0300 [thread overview]
Message-ID: <20150824193356.GB19781@ghost> (raw)
In-Reply-To: <1440336623-5194-1-git-send-email-kdasaparna@gmail.com>
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?
Better. Also, submit it again with proper commit message and put "PATCH v2" in
the subject.
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
> drivers/staging/fbtft/fb_pcd8544.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index cf87ce8..925511f 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,8 +34,8 @@
> #define WIDTH 84
> #define HEIGHT 48
> #define TXBUFLEN (84*6)
> -#define DEFAULT_GAMMA "40"
> /* gamma is used to control contrast in this driver */
Aren't these two supposed to be on the same line? I think your patch is a bit
messed up. Doublecheck this.
> +#define DEFAULT_GAMMA "40"
>
> static unsigned tc;
> module_param(tc, uint, 0);
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2015-08-24 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 13:08 [PATCH] staging: fbtft: Made into two lines Aparna Karuthodi
2015-08-23 7:52 ` Giedrius Statkevičius
2015-08-23 13:30 ` Aparna Karuthodi
2015-08-24 19:08 ` Giedrius Statkevičius
2015-08-24 19:33 ` Giedrius Statkevičius [this message]
2015-08-24 13:11 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824193356.GB19781@ghost \
--to=giedrius.statkevicius@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kdasaparna@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox