From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755414AbbHYIFg (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Aug 2015 04:05:36 -0400
Received: from mail-wi0-f177.google.com ([209.85.212.177]:35884 "EHLO
	mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755252AbbHYIFF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Aug 2015 04:05:05 -0400
Date: Tue, 25 Aug 2015 10:05:00 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
        Michal Marek <mmarek@suse.cz>, Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
        Namhyung Kim <namhyung@gmail.com>,
        Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
        Chris J Arges <chris.j.arges@canonical.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        David Vrabel <david.vrabel@citrix.com>,
        Jeremy Fitzhardinge <jeremy@goop.org>,
        Chris Wright <chrisw@sous-sol.org>, Alok Kataria <akataria@vmware.com>,
        Rusty Russell <rusty@rustcorp.com.au>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>, Pavel Machek <pavel@ucw.cz>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>, Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v11 00/20] Compile-time stack validation
Message-ID: <20150825080500.GA17977@gmail.com>
References: <cover.1440423732.git.jpoimboe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1440423732.git.jpoimboe@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

>  lib/Kconfig.debug                         |  11 +
>  scripts/Makefile                          |   1 +
>  scripts/Makefile.build                    |  37 +-
>  scripts/mod/Makefile                      |   2 +
>  scripts/stackvalidate/Makefile            |  24 +
>  scripts/stackvalidate/arch-x86.c          | 160 +++++
>  scripts/stackvalidate/arch.h              |  44 ++
>  scripts/stackvalidate/elf.c               | 427 +++++++++++++
>  scripts/stackvalidate/elf.h               |  92 +++
>  scripts/stackvalidate/list.h              | 217 +++++++
>  scripts/stackvalidate/special.c           | 199 ++++++
>  scripts/stackvalidate/special.h           |  42 ++
>  scripts/stackvalidate/stackvalidate.c     | 976 ++++++++++++++++++++++++++++++
>  43 files changed, 2803 insertions(+), 48 deletions(-)
>  create mode 100644 Documentation/stack-validation.txt
>  create mode 100644 arch/x86/include/asm/stackvalidate.h
>  create mode 100644 include/linux/stackvalidate.h
>  create mode 100644 scripts/stackvalidate/Makefile
>  create mode 100644 scripts/stackvalidate/arch-x86.c
>  create mode 100644 scripts/stackvalidate/arch.h
>  create mode 100644 scripts/stackvalidate/elf.c
>  create mode 100644 scripts/stackvalidate/elf.h
>  create mode 100644 scripts/stackvalidate/list.h
>  create mode 100644 scripts/stackvalidate/special.c
>  create mode 100644 scripts/stackvalidate/special.h
>  create mode 100644 scripts/stackvalidate/stackvalidate.c

Btw., would you be against putting scripts/stackvalidate/ into 
tools/stackvalidate/ ?

That way it would be more generic, and could be used in a standalone fashion as 
well I suspect. It would not change any of your current usage of it.

(The other Kbuild glue changes still need to be in scripts/.)

Thanks,

	Ingo