From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755903AbbHYOS0 (ORCPT ); Tue, 25 Aug 2015 10:18:26 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:33358 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755172AbbHYOSW (ORCPT ); Tue, 25 Aug 2015 10:18:22 -0400 Date: Tue, 25 Aug 2015 15:18:19 +0100 From: Matt Fleming To: Taku Izumi Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, matt.fleming@intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tony.luck@intel.com, qiuxishi@huawei.com, kamezawa.hiroyu@jp.fujitsu.com, Ard Biesheuvel , Laszlo Ersek , Borislav Petkov Subject: Re: [PATCH 1/2] efi: Add EFI_MEMORY_MORE_RELIABLE support to efi_md_typeattr_format() Message-ID: <20150825141819.GA3013@codeblueprint.co.uk> References: <1440090902-15157-1-git-send-email-izumi.taku@jp.fujitsu.com> <1440090952-15211-1-git-send-email-izumi.taku@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440090952-15211-1-git-send-email-izumi.taku@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Aug, at 02:15:52AM, Taku Izumi wrote: > UEFI spec 2.5 introduces new Memory Attribute Definition named > EFI_MEMORY_MORE_RELIABLE. This patch adds this new attribute > support to efi_md_typeattr_format(). > > Signed-off-by: Taku Izumi > --- > drivers/firmware/efi/efi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > index d6144e3..aadc1c4 100644 > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -589,12 +589,14 @@ char * __init efi_md_typeattr_format(char *buf, size_t size, > attr = md->attribute; > if (attr & ~(EFI_MEMORY_UC | EFI_MEMORY_WC | EFI_MEMORY_WT | > EFI_MEMORY_WB | EFI_MEMORY_UCE | EFI_MEMORY_WP | > - EFI_MEMORY_RP | EFI_MEMORY_XP | EFI_MEMORY_RUNTIME)) > + EFI_MEMORY_RP | EFI_MEMORY_XP | EFI_MEMORY_RUNTIME | > + EFI_MEMORY_MORE_RELIABLE)) > snprintf(pos, size, "|attr=0x%016llx]", > (unsigned long long)attr); > else > - snprintf(pos, size, "|%3s|%2s|%2s|%2s|%3s|%2s|%2s|%2s|%2s]", > + snprintf(pos, size, "|%3s|%4s|%2s|%2s|%2s|%3s|%2s|%2s|%2s|%2s]", > attr & EFI_MEMORY_RUNTIME ? "RUN" : "", > + attr & EFI_MEMORY_MORE_RELIABLE ? "RELY" : "", > attr & EFI_MEMORY_XP ? "XP" : "", > attr & EFI_MEMORY_RP ? "RP" : "", > attr & EFI_MEMORY_WP ? "WP" : "", I'm not keen on using "RELY" because I don't think it's at all obvious what it means. "RELI" would be closer, but still could use some improvement. Since we turned off this kernel output by default (at least on x86) because the line length had grown quite long, maybe we should just embrace it and print "RELIABLE" in full? -- Matt Fleming, Intel Open Source Technology Center