From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
Chris J Arges <chris.j.arges@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Chris Wright <chrisw@sous-sol.org>,
Alok Kataria <akataria@vmware.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Pavel Machek <pavel@ucw.cz>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v11 00/20] Compile-time stack validation
Date: Tue, 25 Aug 2015 10:25:54 -0500 [thread overview]
Message-ID: <20150825152554.GA3724@treble.redhat.com> (raw)
In-Reply-To: <20150825080500.GA17977@gmail.com>
On Tue, Aug 25, 2015 at 10:05:00AM +0200, Ingo Molnar wrote:
> * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > lib/Kconfig.debug | 11 +
> > scripts/Makefile | 1 +
> > scripts/Makefile.build | 37 +-
> > scripts/mod/Makefile | 2 +
> > scripts/stackvalidate/Makefile | 24 +
> > scripts/stackvalidate/arch-x86.c | 160 +++++
> > scripts/stackvalidate/arch.h | 44 ++
> > scripts/stackvalidate/elf.c | 427 +++++++++++++
> > scripts/stackvalidate/elf.h | 92 +++
> > scripts/stackvalidate/list.h | 217 +++++++
> > scripts/stackvalidate/special.c | 199 ++++++
> > scripts/stackvalidate/special.h | 42 ++
> > scripts/stackvalidate/stackvalidate.c | 976 ++++++++++++++++++++++++++++++
> > 43 files changed, 2803 insertions(+), 48 deletions(-)
> > create mode 100644 Documentation/stack-validation.txt
> > create mode 100644 arch/x86/include/asm/stackvalidate.h
> > create mode 100644 include/linux/stackvalidate.h
> > create mode 100644 scripts/stackvalidate/Makefile
> > create mode 100644 scripts/stackvalidate/arch-x86.c
> > create mode 100644 scripts/stackvalidate/arch.h
> > create mode 100644 scripts/stackvalidate/elf.c
> > create mode 100644 scripts/stackvalidate/elf.h
> > create mode 100644 scripts/stackvalidate/list.h
> > create mode 100644 scripts/stackvalidate/special.c
> > create mode 100644 scripts/stackvalidate/special.h
> > create mode 100644 scripts/stackvalidate/stackvalidate.c
>
> Btw., would you be against putting scripts/stackvalidate/ into
> tools/stackvalidate/ ?
>
> That way it would be more generic, and could be used in a standalone fashion as
> well I suspect. It would not change any of your current usage of it.
>
> (The other Kbuild glue changes still need to be in scripts/.)
I like that idea. It could indeed be useful for any other projects
which have asm code. In fact the musl project has been trying to solve
similar problems with their CFI generation awk script.
It does have some kernel-isms related to the reading of special sections
(.altinstructions, __jump_table, etc). But that should be harmless for
non-kernel code and could easily be factored out with a compile-time or
cmdline flag if needed.
BTW, since I'm planning on adding a CFI generation option to this tool,
I wonder if "stackvalidate" is a misnomer. I can't think of anything
better. Any naming ideas are welcome :-)
--
Josh
next prev parent reply other threads:[~2015-08-25 15:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 14:45 [PATCH v11 00/20] Compile-time stack validation Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 01/20] x86/asm: Frame pointer macro cleanup Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 02/20] x86/asm: Add C versions of frame pointer macros Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 03/20] x86/stackvalidate: Compile-time stack validation Josh Poimboeuf
2015-08-26 14:26 ` Andi Kleen
2015-08-27 14:29 ` Josh Poimboeuf
2015-08-28 17:26 ` Andi Kleen
2015-08-28 19:54 ` Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 04/20] x86/stackvalidate: Add file and directory ignores Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 05/20] x86/stackvalidate: Add ignore macros Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 06/20] x86/xen: Add stack frame dependency to hypercall inline asm calls Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 07/20] x86/paravirt: Add stack frame dependency to PVOP " Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 08/20] x86/paravirt: Create a stack frame in PV_CALLEE_SAVE_REGS_THUNK Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 09/20] x86/amd: Set ELF function type for vide() Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 10/20] x86/reboot: Add ljmp instructions to stackvalidate whitelist Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 11/20] x86/xen: Add xen_cpuid() and xen_setup_gdt() to stackvalidate whitelists Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 12/20] x86/asm/crypto: Create stack frames in aesni-intel_asm.S Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 13/20] x86/asm/crypto: Move .Lbswap_mask data to .rodata section Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 14/20] x86/asm/crypto: Move jump_table " Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 15/20] x86/asm/crypto: Create stack frames in clmul_ghash_mul/update() Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 16/20] x86/asm/entry: Create stack frames in thunk functions Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 17/20] x86/asm/acpi: Create a stack frame in do_suspend_lowlevel() Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 18/20] x86/asm: Create stack frames in rwsem functions Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 19/20] x86/asm/efi: Create a stack frame in efi_call() Josh Poimboeuf
2015-08-24 14:46 ` [PATCH v11 20/20] x86/asm/power: Create stack frames in hibernate_asm_64.S Josh Poimboeuf
2015-08-25 8:05 ` [PATCH v11 00/20] Compile-time stack validation Ingo Molnar
2015-08-25 15:25 ` Josh Poimboeuf [this message]
2015-08-26 7:07 ` Ingo Molnar
2015-08-26 8:44 ` Jiri Kosina
2015-08-27 13:11 ` Josh Poimboeuf
2015-08-28 8:21 ` Ingo Molnar
2015-08-28 13:54 ` Josh Poimboeuf
2015-09-14 13:19 ` Ingo Molnar
2015-09-14 14:10 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825152554.GA3724@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bernd@petrovitsch.priv.at \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=chris.j.arges@canonical.com \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=namhyung@gmail.com \
--cc=palves@redhat.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox