From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933303AbbHZBgP (ORCPT ); Tue, 25 Aug 2015 21:36:15 -0400 Received: from mail1.windriver.com ([147.11.146.13]:44444 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932758AbbHZBgO (ORCPT ); Tue, 25 Aug 2015 21:36:14 -0400 Date: Tue, 25 Aug 2015 21:36:01 -0400 From: Paul Gortmaker To: "Paul E. McKenney" CC: Josh Triplett , , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan Subject: Re: [PATCH] kernel: make rcu/tree_trace.c explicitly non-modular Message-ID: <20150826013601.GA6085@windriver.com> References: <1440516197-25370-1-git-send-email-paul.gortmaker@windriver.com> <20150825162928.GA28226@x> <20150825181109.GB3560@windriver.com> <20150825223728.GP11078@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150825223728.GP11078@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH] kernel: make rcu/tree_trace.c explicitly non-modular] On 25/08/2015 (Tue 15:37) Paul E. McKenney wrote: > On Tue, Aug 25, 2015 at 02:11:09PM -0400, Paul Gortmaker wrote: > > [Re: [PATCH] kernel: make rcu/tree_trace.c explicitly non-modular] On 25/08/2015 (Tue 09:29) Josh Triplett wrote: > > > > > On Tue, Aug 25, 2015 at 11:23:17AM -0400, Paul Gortmaker wrote: > > > > The Kconfig currently controlling compilation of this code is: > > > > > > > > init/Kconfig:config TREE_RCU_TRACE > > > > init/Kconfig: def_bool RCU_TRACE && ( TREE_RCU || PREEMPT_RCU ) > > > > > > > > ...meaning that it currently is not being built as a module by anyone. > > > > > > > > Lets remove the modular code that is essentially orphaned, so that > > > > when reading the file there is no doubt it is builtin-only. > > > > > > > > Since module_init translates to device_initcall in the non-modular > > > > case, the init ordering remains unchanged with this commit. We could > > > > consider moving this to an earlier initcall if desired. > > > > > > > > We don't replace module.h with init.h since the file already has that. > > > > We also delete the moduleparam.h include that is left over from > > > > commit 64db4cfff99c04cd5f550357edcc8780f96b54a2 (""Tree RCU": scalable > > > > classic RCU implementation") since it is not needed here either. > > > > > > > > We leave some tags like MODULE_AUTHOR for documentation purposes. > > > > > > > > Cc: "Paul E. McKenney" > > > > Cc: Josh Triplett > > > > Cc: Steven Rostedt > > > > Cc: Mathieu Desnoyers > > > > Cc: Lai Jiangshan > > > > Signed-off-by: Paul Gortmaker > > > > > > Seems reasonable, though leaving the MODULE_* metadata commented out at > > > the end seems odd. I'd suggest using the DESCRIPTION to update the > > > > That was largely driven by the desire to make as minimalist change as > > possible... > > This would be for v4.4, so getting rid of the three "MODULE_*" lines > at the end makes sense, as does moving any needed info to the comment > block at the beginning of the file. OK, no problem. > > > > comment at the top (which is actually outdated and needs > > > s/classic/hierarchical/), dropping the MODULE_LICENSE (redundant with > > > the license header), and changing "MODULE_AUTHOR" into an "Author:" > > > under the copyright. > > > > ...but I can also do it that way too; fine by me. I'll wait a bit to > > give Paul a chance to comment before resending, in case he also wants > > some changes. > > The "classic" is indeed obsolete, may as well change it while we are > at it. I was concerned about the THIS_MODULE instances, but this appears > to be defined even for non-module builds, so should be OK. Ah, ye of little faith. I dealt with THIS_MODULE in f5016932, now over four years ago (gasp!) > > So please do send a patch with the changes Josh called out. Will do. Thanks, Paul. -- > > Thanx, Paul >