From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933213AbbHZL7F (ORCPT ); Wed, 26 Aug 2015 07:59:05 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38046 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932672AbbHZL7D (ORCPT ); Wed, 26 Aug 2015 07:59:03 -0400 Date: Wed, 26 Aug 2015 12:58:56 +0100 From: Lee Jones To: Philipp Zabel Cc: Thierry Reding , Jingoo Han , Ajay Kumar , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2] pwm-backlight: Avoid backlight flicker when probed from DT Message-ID: <20150826115856.GY19409@x1> References: <1438276973-20920-1-git-send-email-p.zabel@pengutronix.de> <1440580842.3190.26.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440580842.3190.26.camel@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Aug 2015, Philipp Zabel wrote: > Hi Thierry, Jingoo, Lee, > > Am Donnerstag, den 30.07.2015, 19:22 +0200 schrieb Philipp Zabel: > > If the driver is probed from the device tree, and there is a phandle > > property set on it, and the enable GPIO is already configured as output, > > and the backlight is currently disabled, keep it disabled. > > If all these conditions are met, assume there will be some other driver > > that can enable the backlight at the appropriate time. > > do you have any comments on this? > > This patch fixes premature backlight illumination issues for DT probed > devices with enable gpio or regulator without changing the behavior of > the non-DT case or DT cases where the enable gpio and regulator are kept > initially enabled or where no other device node points to the backlight > via phandle. I need Thierry's review to move forward on this. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog