From: Matt Fleming <matt@codeblueprint.co.uk>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>,
Peter Jones <pjones@redhat.com>,
linux-efi@vger.kernel.org
Subject: Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular
Date: Wed, 26 Aug 2015 18:11:28 +0100 [thread overview]
Message-ID: <20150826171128.GA2837@codeblueprint.co.uk> (raw)
In-Reply-To: <1440543648-27328-1-git-send-email-paul.gortmaker@windriver.com>
On Tue, 25 Aug, at 07:00:48PM, Paul Gortmaker wrote:
> The Kconfig for this driver is currently hidden with:
>
> config EFI_ESRT
> bool
>
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
>
> We leave some tags like MODULE_AUTHOR for documentation purposes.
>
> We don't replace module.h with init.h since the file already has that.
>
> Cc: Matt Fleming <matt.fleming@intel.com>
> Cc: Peter Jones <pjones@redhat.com>
> Cc: linux-efi@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Looks good to me. I know Peter is on vacation right now, so I'm still
expecting a response from him. In the meantime, I'll queue this up in
the EFI 'next' branch. Thanks!
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-08-26 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 23:00 [PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular Paul Gortmaker
2015-08-26 17:11 ` Matt Fleming [this message]
2015-08-31 13:52 ` Peter Jones
2015-09-01 8:57 ` Matt Fleming
2015-09-01 13:19 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826171128.GA2837@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=paul.gortmaker@windriver.com \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox