From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752513AbbHZRsk (ORCPT ); Wed, 26 Aug 2015 13:48:40 -0400 Received: from muru.com ([72.249.23.125]:46544 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbHZRsj (ORCPT ); Wed, 26 Aug 2015 13:48:39 -0400 Date: Wed, 26 Aug 2015 10:48:36 -0700 From: Tony Lindgren To: Jeremy Linton Cc: Guenter Roeck , Steve Glendinning , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" Subject: Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used Message-ID: <20150826174835.GQ4215@atomide.com> References: <1439844336-21596-1-git-send-email-linux@roeck-us.net> <20150826170410.GP4215@atomide.com> <55DDF7F8.2030304@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55DDF7F8.2030304@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jeremy Linton [150826 10:35]: > On 08/26/2015 12:04 PM, Tony Lindgren wrote: > >* Guenter Roeck [150817 13:48]: > >>Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes > >Looks like this change makes at least omap boards using smsc911x > >fail with -22 for me in Linux next. > > > >Do any of the the device tree configured smsc911x devices actually > >have a phy configured? > > Tony, > > Looks like all the ones in the kernel boot/dts directory have a phy > including the omap3-lilly except for the ste-snowball.dts. > > Do you have smsc,force-internal-phy set instead? Hmm most of them are using omap-gpmc-smsc911x.dtsi and omap-gpmc-smsc9221.dtsi which are set up the same way as omap3-lilly. So no phy. Regards, Tony