From: Calvin Owens <calvinowens@fb.com>
To: "Nicholas A. Bellinger" <nab@daterainc.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Christoph Hellwig <hch@infradead.org>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
"MPT-FusionLinux.pdl" <MPT-FusionLinux.pdl@avagotech.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Subject: Re: [PATCH 2/2] mpt3sas: Refcount fw_events and fix unsafe list usage
Date: Wed, 26 Aug 2015 19:06:32 -0700 [thread overview]
Message-ID: <20150827020632.GA12485@mail.thefacebook.com> (raw)
In-Reply-To: <1440562184-23945-3-git-send-email-nab@daterainc.com>
On Wednesday 08/26 at 04:09 +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> The fw_event_work struct is concurrently referenced at shutdown, so
> add a refcount to protect it, and refactor the code to use it.
>
> Additionally, refactor _scsih_fw_event_cleanup_queue() such that it
> no longer iterates over the list without holding the lock, since
> _firmware_event_work() concurrently deletes items from the list.
>
> This patch is a port of Calvin's PATCH-v4 for mpt2sas code.
>
> Cc: Calvin Owens <calvinowens@fb.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Sreekanth Reddy <sreekanth.reddy@avagotech.com>
> Cc: MPT-FusionLinux.pdl <MPT-FusionLinux.pdl@avagotech.com>
> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
> ---
> drivers/scsi/mpt3sas/mpt3sas_scsih.c | 116 ++++++++++++++++++++++++++++-------
> 1 file changed, 94 insertions(+), 22 deletions(-)
Looks good, thanks again for this.
Reviewed-by: Calvin Owens <calvinowens@fb.com>
next prev parent reply other threads:[~2015-08-27 2:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 4:09 [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas Nicholas A. Bellinger
2015-08-26 4:09 ` [PATCH 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage Nicholas A. Bellinger
2015-08-27 2:20 ` Calvin Owens
2015-08-26 4:09 ` [PATCH 2/2] mpt3sas: Refcount fw_events " Nicholas A. Bellinger
2015-08-27 2:06 ` Calvin Owens [this message]
2015-08-26 23:54 ` [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas Calvin Owens
2015-08-26 23:58 ` Nicholas A. Bellinger
2015-08-27 5:07 ` Sreekanth Reddy
2015-08-27 7:07 ` Nicholas A. Bellinger
2015-08-27 14:40 ` James Bottomley
2015-08-27 14:48 ` Sreekanth Reddy
2015-08-27 19:15 ` Nicholas A. Bellinger
2015-08-28 20:25 ` James Bottomley
2015-08-30 7:22 ` Nicholas A. Bellinger
2015-08-30 16:14 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827020632.GA12485@mail.thefacebook.com \
--to=calvinowens@fb.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=MPT-FusionLinux.pdl@avagotech.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=sreekanth.reddy@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).