* [PATCH] leds: leds-cobalt-qube: Use devm_led_classdev_register
@ 2015-08-27 5:13 Vaishali Thakkar
2015-08-27 7:26 ` Jacek Anaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Vaishali Thakkar @ 2015-08-27 5:13 UTC (permalink / raw)
To: Richard Purdie; +Cc: Jacek Anaszewski, linux-leds, linux-kernel
Use resource-managed function devm_led_classdev_register instead
of led_classdev_register to make the error-path simpler.
To be compatible with the change, goto is replaced with direct
return and unneeded label is dropped. Also, remove redundant
cobalt_qube_led_remove.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
drivers/leds/leds-cobalt-qube.c | 20 ++------------------
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/drivers/leds/leds-cobalt-qube.c b/drivers/leds/leds-cobalt-qube.c
index d975220..59818df 100644
--- a/drivers/leds/leds-cobalt-qube.c
+++ b/drivers/leds/leds-cobalt-qube.c
@@ -49,31 +49,15 @@ static int cobalt_qube_led_probe(struct platform_device *pdev)
led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT;
writeb(led_value, led_port);
- retval = led_classdev_register(&pdev->dev, &qube_front_led);
+ retval = devm_led_classdev_register(&pdev->dev, &qube_front_led);
if (retval)
- goto err_null;
-
- return 0;
-
-err_null:
- led_port = NULL;
-
- return retval;
-}
-
-static int cobalt_qube_led_remove(struct platform_device *pdev)
-{
- led_classdev_unregister(&qube_front_led);
-
- if (led_port)
- led_port = NULL;
+ return retval;
return 0;
}
static struct platform_driver cobalt_qube_led_driver = {
.probe = cobalt_qube_led_probe,
- .remove = cobalt_qube_led_remove,
.driver = {
.name = "cobalt-qube-leds",
},
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] leds: leds-cobalt-qube: Use devm_led_classdev_register
2015-08-27 5:13 [PATCH] leds: leds-cobalt-qube: Use devm_led_classdev_register Vaishali Thakkar
@ 2015-08-27 7:26 ` Jacek Anaszewski
2015-08-28 8:19 ` Vaishali Thakkar
0 siblings, 1 reply; 3+ messages in thread
From: Jacek Anaszewski @ 2015-08-27 7:26 UTC (permalink / raw)
To: Vaishali Thakkar; +Cc: Richard Purdie, linux-leds, linux-kernel
Hi Vaishali,
Thanks for the patch.
On 08/27/2015 07:13 AM, Vaishali Thakkar wrote:
> Use resource-managed function devm_led_classdev_register instead
> of led_classdev_register to make the error-path simpler.
>
> To be compatible with the change, goto is replaced with direct
> return and unneeded label is dropped. Also, remove redundant
> cobalt_qube_led_remove.
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> drivers/leds/leds-cobalt-qube.c | 20 ++------------------
> 1 file changed, 2 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/leds/leds-cobalt-qube.c b/drivers/leds/leds-cobalt-qube.c
> index d975220..59818df 100644
> --- a/drivers/leds/leds-cobalt-qube.c
> +++ b/drivers/leds/leds-cobalt-qube.c
> @@ -49,31 +49,15 @@ static int cobalt_qube_led_probe(struct platform_device *pdev)
> led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT;
> writeb(led_value, led_port);
>
> - retval = led_classdev_register(&pdev->dev, &qube_front_led);
> + retval = devm_led_classdev_register(&pdev->dev, &qube_front_led);
> if (retval)
> - goto err_null;
We can spare more lines by changing this to:
return devm_led_classdev_register(&pdev->dev, &qube_front_led);
You could get rid of retval then, too.
> -
> - return 0;
> -
> -err_null:
> - led_port = NULL;
> -
> - return retval;
> -}
> -
> -static int cobalt_qube_led_remove(struct platform_device *pdev)
> -{
> - led_classdev_unregister(&qube_front_led);
> -
> - if (led_port)
> - led_port = NULL;
> + return retval;
>
> return 0;
> }
>
> static struct platform_driver cobalt_qube_led_driver = {
> .probe = cobalt_qube_led_probe,
> - .remove = cobalt_qube_led_remove,
> .driver = {
> .name = "cobalt-qube-leds",
> },
>
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] leds: leds-cobalt-qube: Use devm_led_classdev_register
2015-08-27 7:26 ` Jacek Anaszewski
@ 2015-08-28 8:19 ` Vaishali Thakkar
0 siblings, 0 replies; 3+ messages in thread
From: Vaishali Thakkar @ 2015-08-28 8:19 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: Richard Purdie, linux-leds, Linux Kernel Mailing List
On Thu, Aug 27, 2015 at 12:56 PM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> Hi Vaishali,
>
> Thanks for the patch.
>
> On 08/27/2015 07:13 AM, Vaishali Thakkar wrote:
>>
>> Use resource-managed function devm_led_classdev_register instead
>> of led_classdev_register to make the error-path simpler.
>>
>> To be compatible with the change, goto is replaced with direct
>> return and unneeded label is dropped. Also, remove redundant
>> cobalt_qube_led_remove.
>>
>> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
>> ---
>> drivers/leds/leds-cobalt-qube.c | 20 ++------------------
>> 1 file changed, 2 insertions(+), 18 deletions(-)
>>
>> diff --git a/drivers/leds/leds-cobalt-qube.c
>> b/drivers/leds/leds-cobalt-qube.c
>> index d975220..59818df 100644
>> --- a/drivers/leds/leds-cobalt-qube.c
>> +++ b/drivers/leds/leds-cobalt-qube.c
>> @@ -49,31 +49,15 @@ static int cobalt_qube_led_probe(struct
>> platform_device *pdev)
>> led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT;
>> writeb(led_value, led_port);
>>
>> - retval = led_classdev_register(&pdev->dev, &qube_front_led);
>> + retval = devm_led_classdev_register(&pdev->dev, &qube_front_led);
>> if (retval)
>> - goto err_null;
>
>
> We can spare more lines by changing this to:
>
> return devm_led_classdev_register(&pdev->dev, &qube_front_led);
>
> You could get rid of retval then, too.
Sure. This makes sense. I will send v2 with the change.
Thanks.
>> -
>> - return 0;
>> -
>> -err_null:
>> - led_port = NULL;
>> -
>> - return retval;
>> -}
>> -
>> -static int cobalt_qube_led_remove(struct platform_device *pdev)
>> -{
>> - led_classdev_unregister(&qube_front_led);
>> -
>> - if (led_port)
>> - led_port = NULL;
>> + return retval;
>>
>> return 0;
>> }
>>
>> static struct platform_driver cobalt_qube_led_driver = {
>> .probe = cobalt_qube_led_probe,
>> - .remove = cobalt_qube_led_remove,
>> .driver = {
>> .name = "cobalt-qube-leds",
>> },
>>
>
>
> --
> Best Regards,
> Jacek Anaszewski
--
Vaishali
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-28 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-27 5:13 [PATCH] leds: leds-cobalt-qube: Use devm_led_classdev_register Vaishali Thakkar
2015-08-27 7:26 ` Jacek Anaszewski
2015-08-28 8:19 ` Vaishali Thakkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox