* [PATCH v2] s390/jump_label: Use %*ph to print small buffers
@ 2015-08-26 19:17 Alexander Kuleshov
2015-08-27 7:34 ` Martin Schwidefsky
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Kuleshov @ 2015-08-26 19:17 UTC (permalink / raw)
To: Martin Schwidefsky, Heiko Carstens
Cc: linux390, linux-s390, linux-kernel, Alexander Kuleshov
printk() supports %*ph format specifier for printing a small buffers,
let's use it intead of %02x %02x...
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
arch/s390/kernel/jump_label.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/s390/kernel/jump_label.c b/arch/s390/kernel/jump_label.c
index a902996..1f615f3 100644
--- a/arch/s390/kernel/jump_label.c
+++ b/arch/s390/kernel/jump_label.c
@@ -44,12 +44,9 @@ static void jump_label_bug(struct jump_entry *entry, struct insn *expected,
unsigned char *ipn = (unsigned char *)new;
pr_emerg("Jump label code mismatch at %pS [%p]\n", ipc, ipc);
- pr_emerg("Found: %02x %02x %02x %02x %02x %02x\n",
- ipc[0], ipc[1], ipc[2], ipc[3], ipc[4], ipc[5]);
- pr_emerg("Expected: %02x %02x %02x %02x %02x %02x\n",
- ipe[0], ipe[1], ipe[2], ipe[3], ipe[4], ipe[5]);
- pr_emerg("New: %02x %02x %02x %02x %02x %02x\n",
- ipn[0], ipn[1], ipn[2], ipn[3], ipn[4], ipn[5]);
+ pr_emerg("Found: %6ph\n", ipc);
+ pr_emerg("Expected: %6ph\n", ipe);
+ pr_emerg("New: %6ph\n", ipn);
panic("Corrupted kernel text");
}
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] s390/jump_label: Use %*ph to print small buffers
2015-08-26 19:17 [PATCH v2] s390/jump_label: Use %*ph to print small buffers Alexander Kuleshov
@ 2015-08-27 7:34 ` Martin Schwidefsky
0 siblings, 0 replies; 2+ messages in thread
From: Martin Schwidefsky @ 2015-08-27 7:34 UTC (permalink / raw)
To: Alexander Kuleshov; +Cc: Heiko Carstens, linux390, linux-s390, linux-kernel
On Thu, 27 Aug 2015 01:17:46 +0600
Alexander Kuleshov <kuleshovmail@gmail.com> wrote:
> printk() supports %*ph format specifier for printing a small buffers,
> let's use it intead of %02x %02x...
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> arch/s390/kernel/jump_label.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/s390/kernel/jump_label.c b/arch/s390/kernel/jump_label.c
> index a902996..1f615f3 100644
> --- a/arch/s390/kernel/jump_label.c
> +++ b/arch/s390/kernel/jump_label.c
> @@ -44,12 +44,9 @@ static void jump_label_bug(struct jump_entry *entry, struct insn *expected,
> unsigned char *ipn = (unsigned char *)new;
>
> pr_emerg("Jump label code mismatch at %pS [%p]\n", ipc, ipc);
> - pr_emerg("Found: %02x %02x %02x %02x %02x %02x\n",
> - ipc[0], ipc[1], ipc[2], ipc[3], ipc[4], ipc[5]);
> - pr_emerg("Expected: %02x %02x %02x %02x %02x %02x\n",
> - ipe[0], ipe[1], ipe[2], ipe[3], ipe[4], ipe[5]);
> - pr_emerg("New: %02x %02x %02x %02x %02x %02x\n",
> - ipn[0], ipn[1], ipn[2], ipn[3], ipn[4], ipn[5]);
> + pr_emerg("Found: %6ph\n", ipc);
> + pr_emerg("Expected: %6ph\n", ipe);
> + pr_emerg("New: %6ph\n", ipn);
> panic("Corrupted kernel text");
> }
Nice. Applied to the s390 features branch. Thanks.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-27 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-26 19:17 [PATCH v2] s390/jump_label: Use %*ph to print small buffers Alexander Kuleshov
2015-08-27 7:34 ` Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox