Re: [PATCH v5 5/5] PM / devfreq: drop comment about thermal setting max_freq

Re: [PATCH v5 5/5] PM / devfreq: drop comment about thermal setting max_freq

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 690 bytes --]

> The thermal infrastructure should use the devfreq cooling device, which
> uses the OPP library to disable OPPs as necessary.
> 
> Fix a couple of typos in the same comment while we are at it.
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Javi Merino <javi.merino@arm.com>

Your patches (1/5, 5/5) are already merged in https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git
and will be "pull-request"ed with other patches later.

Do your "V5" patches have updates from last patches?


Cheers,
MyungJoo
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH v5 5/5] PM / devfreq: drop comment about thermal setting max_freq

[Javi Merino]

On Thu, Aug 27, 2015 at 11:58:39AM +0100, MyungJoo Ham wrote:
> > The thermal infrastructure should use the devfreq cooling device, which
> > uses the OPP library to disable OPPs as necessary.
> > 
> > Fix a couple of typos in the same comment while we are at it.
> > 
> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> > Signed-off-by: Javi Merino <javi.merino@arm.com>
> 
> Your patches (1/5, 5/5) are already merged in https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git
> and will be "pull-request"ed with other patches later.
> 
> Do your "V5" patches have updates from last patches?

No they haven't.  I should have based this series on top of your
branch.  I'll do that in the future.

Sorry for that,
Javi

[PATCH v5 0/5] Devfreq cooling device

[Javi Merino]

This series introduces a devfreq cooling device in the thermal
framework.  Devfreq is used for DVFS for devices other than the CPUs.
With a devfreq cooling device, the thermal framework can throttle them
to control temperature.  The cooling device has the power extensions,
so it can be used by all governors in the thermal framework, including
the power allocator governor.

Changes since v4:
  - Don't introduce a new function in the OPP library and instead fix
    dev_pm_opp_get_voltage() as suggested by Viresh Kumar
  - Don't allocate memory under RCU
  - Don't call dev_pm_opp_enable/disable under RCU
  - Generate the frequency table even if the power extensions were
    not provided

Changes since v3:
  - Made devfreq_update_stats() a static inline function
  - Add dev_pm_get_voltage_always() to get the voltage even for
    disabled OPPs
  - Don't rely on freq_table from the devfreq->profile being present
    and create our own
  - Don't use devm_k* to allocate memory
  - Move struct devfreq_cooling_register to devfreq_cooling.c

Javi Merino (4):
  PM / devfreq: cache the last call to get_dev_status()
  PM / OPP: get the voltage for all OPPs
  devfreq_cooling: add trace information
  PM / devfreq: drop comment about thermal setting max_freq

Ørjan Eide (1):
  thermal: Add devfreq cooling

 drivers/base/power/opp.c                  |   4 +-
 drivers/devfreq/devfreq.c                 |   6 +-
 drivers/devfreq/governor_simpleondemand.c |  33 +-
 drivers/thermal/Kconfig                   |  11 +
 drivers/thermal/Makefile                  |   3 +
 drivers/thermal/devfreq_cooling.c         | 552 ++++++++++++++++++++++++++++++
 include/linux/devfreq.h                   |  15 +
 include/linux/devfreq_cooling.h           |  72 ++++
 include/trace/events/thermal.h            |  53 +++
 9 files changed, 729 insertions(+), 20 deletions(-)
 create mode 100644 drivers/thermal/devfreq_cooling.c
 create mode 100644 include/linux/devfreq_cooling.h

-- 
1.9.1

[PATCH v5 5/5] PM / devfreq: drop comment about thermal setting max_freq

[Javi Merino]

The thermal infrastructure should use the devfreq cooling device, which
uses the OPP library to disable OPPs as necessary.

Fix a couple of typos in the same comment while we are at it.

Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Javi Merino <javi.merino@arm.com>
---
 drivers/devfreq/devfreq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index ca1b362d77e2..aed1137b2173 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -177,10 +177,10 @@ int update_devfreq(struct devfreq *devfreq)
 		return err;
 
 	/*
-	 * Adjust the freuqency with user freq and QoS.
+	 * Adjust the frequency with user freq and QoS.
 	 *
-	 * List from the highest proiority
-	 * max_freq (probably called by thermal when it's too hot)
+	 * List from the highest priority
+	 * max_freq
 	 * min_freq
 	 */
 
-- 
1.9.1