From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Minchan Kim <minchan@kernel.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, arc-linux-dev@synopsys.com
Subject: Re: [PATCH 04/11] ARCv2: mm: THP support
Date: Thu, 27 Aug 2015 18:32:54 +0300 [thread overview]
Message-ID: <20150827153254.GA21103@node.dhcp.inet.fi> (raw)
In-Reply-To: <1440666194-21478-5-git-send-email-vgupta@synopsys.com>
On Thu, Aug 27, 2015 at 02:33:07PM +0530, Vineet Gupta wrote:
> +pgtable_t pgtable_trans_huge_withdraw(struct mm_struct *mm, pmd_t *pmdp)
> +{
> + struct list_head *lh;
> + pgtable_t pgtable;
> + pte_t *ptep;
> +
> + assert_spin_locked(&mm->page_table_lock);
> +
> + pgtable = pmd_huge_pte(mm, pmdp);
> + lh = (struct list_head *) pgtable;
> + if (list_empty(lh))
> + pmd_huge_pte(mm, pmdp) = (pgtable_t) NULL;
> + else {
> + pmd_huge_pte(mm, pmdp) = (pgtable_t) lh->next;
> + list_del(lh);
> + }
Side question: why pgtable_t is unsigned long on ARC and not struct page *
or pte_t *, like on other archs? We could avoid these casts.
--
Kirill A. Shutemov
next parent reply other threads:[~2015-08-27 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1440666194-21478-1-git-send-email-vgupta@synopsys.com>
[not found] ` <1440666194-21478-5-git-send-email-vgupta@synopsys.com>
2015-08-27 15:32 ` Kirill A. Shutemov [this message]
2015-08-27 16:56 ` [PATCH 04/11] ARCv2: mm: THP support Vineet Gupta
[not found] ` <1440666194-21478-9-git-send-email-vgupta@synopsys.com>
2015-09-16 22:25 ` [PATCH 08/11] mm,thp: reduce ifdef'ery for THP in generic code Andrew Morton
[not found] ` <1440666194-21478-10-git-send-email-vgupta@synopsys.com>
2015-09-16 22:26 ` [PATCH 09/11] mm,thp: introduce flush_pmd_tlb_range Andrew Morton
2015-09-16 22:27 ` [PATCH 00/11] THP support for ARC Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827153254.GA21103@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=Vineet.Gupta1@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arc-linux-dev@synopsys.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox