From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752947AbbH0SYc (ORCPT ); Thu, 27 Aug 2015 14:24:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42891 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbbH0SYb (ORCPT ); Thu, 27 Aug 2015 14:24:31 -0400 Date: Thu, 27 Aug 2015 20:24:26 +0200 From: Jiri Olsa To: "Liang, Kan" Cc: "acme@kernel.org" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "jolsa@kernel.org" , "namhyung@kernel.org" , "ak@linux.intel.com" , "eranian@google.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RFC 02/10] perf,tools: Support new sort type --socket Message-ID: <20150827182426.GA16947@krava.redhat.com> References: <1439889946-28986-1-git-send-email-kan.liang@intel.com> <1439889946-28986-3-git-send-email-kan.liang@intel.com> <20150820090913.GB1672@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F077018F1D04@SHSMSX103.ccr.corp.intel.com> <20150823220011.GC11582@krava.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F077018F21A5@SHSMSX103.ccr.corp.intel.com> <20150824142753.GB3699@krava.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F077018F224F@SHSMSX103.ccr.corp.intel.com> <20150824193021.GE3699@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150824193021.GE3699@krava.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2015 at 09:30:21PM +0200, Jiri Olsa wrote: > On Mon, Aug 24, 2015 at 04:47:12PM +0000, Liang, Kan wrote: > > > > > > > On Mon, Aug 24, 2015 at 02:22:08PM +0000, Liang, Kan wrote: > > > > > > > > > > On Fri, Aug 21, 2015 at 08:25:24PM +0000, Liang, Kan wrote: > > > > > > > > > > SNIP > > > > > > > > > > > > > > > > > > > we need global topology information in perf.data and use the > > > > > > > mapping from there, we can't use current server info > > > > > > > > > > > > > > we currently store core_siblings_list and thread_siblings_list, > > > > > > > in topology FEATURE, which is probably not enough > > > > > > > > > > > > > > > > > > > core_siblings_list includes the cpu list in the same socket. > > > > > > thread_siblings_list includes the cpu list in the same core. > > > > > > numa_nodes includes the cpu list for each node. > > > > > > > > > > > > It looks we have enough data from topology FEATURE. > > > > > > > > > > hum, haven't hecked deeply.. how will you get core id for cpu? > > > > > > > > > > > > > from thread_siblings_list. > > > > I just noticed that svg_build_topology_map did the similar thing to > > > > get topology map for timechart from perf header. > > > > > > could you please provide both functions then cpu -> core, cpu -> socket > > > > > > > Do you mean something like this? > > Store cpu->socket and cpu->core in perf_session_env. > > yep, seems ok any chance you could send out this one? I'd need to use it in my other stuff thanks, jirka