From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbbH1HBH (ORCPT ); Fri, 28 Aug 2015 03:01:07 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35657 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbbH1HBE (ORCPT ); Fri, 28 Aug 2015 03:01:04 -0400 Date: Fri, 28 Aug 2015 08:01:00 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, srinivas.kandagatla@gmail.com, patrice.chotard@st.com, mchehab@osg.samsung.com, devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2 2/5] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node. Message-ID: <20150828070100.GF4796@x1> References: <1440678575-21646-1-git-send-email-peter.griffin@linaro.org> <1440678575-21646-3-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440678575-21646-3-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Aug 2015, Peter Griffin wrote: > This patch adds in the required DT node for the c8sectpfe > Linux DVB demux driver which allows the tsin channels > to be used on an upstream kernel. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stihxxx-b2120.dtsi | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi > index 62994ae..c014173 100644 > --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi > +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi > @@ -6,6 +6,9 @@ > * it under the terms of the GNU General Public License version 2 as > * published by the Free Software Foundation. > */ > + > +#include > +#include > / { > soc { > sbc_serial0: serial@9530000 { > @@ -85,5 +88,36 @@ > status = "okay"; > }; > > + demux@08a20000 { > + compatible = "st,stih407-c8sectpfe"; > + status = "okay"; > + reg = <0x08a20000 0x10000>, > + <0x08a00000 0x4000>; These look like they're the wrong way round. > + reg-names = "c8sectpfe", "c8sectpfe-ram"; > + interrupts = , > + ; > + interrupt-names = "c8sectpfe-error-irq", > + "c8sectpfe-idle-irq"; > + pinctrl-names = "tsin0-serial", > + "tsin0-parallel", > + "tsin3-serial", > + "tsin4-serial", > + "tsin5-serial"; > + pinctrl-0 = <&pinctrl_tsin0_serial>; > + pinctrl-1 = <&pinctrl_tsin0_parallel>; > + pinctrl-2 = <&pinctrl_tsin3_serial>; > + pinctrl-3 = <&pinctrl_tsin4_serial_alt3>; > + pinctrl-4 = <&pinctrl_tsin5_serial_alt1>; > + clock-names = "c8sectpfe"; > + clocks = <&clk_s_c0_flexgen CLK_PROC_STFE>; Personal preferenc is that the *-names properties should come *after* the ones they reference. > + /* tsin0 is TSA on NIMA */ > + tsin0: port@0 { > + tsin-num = <0>; > + serial-not-parallel; > + i2c-bus = <&ssc2>; > + rst-gpio = <&pio15 4 0>; "reset-gpios"? Use the GPIO DEFINES. > + dvb-card = ; > + }; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog