Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit

Ingo Molnar
2015-08-29T09:19:21Z

* Ingo Molnar <mingo@kernel.org> wrote:

>
> * Borislav Petkov <bp@alien8.de> wrote:
>
> > On Thu, Aug 27, 2015 at 04:07:40PM +0800, Huang Rui wrote:
> > > Add an accessor function amd_get_cores_per_cu() which returns the
> > > number of cores per compute unit.
> > >
> > > In a subsequent patch, we will use this function in fam15h_power
> > > driver.
> > >
> > > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > > ---
> > > arch/x86/include/asm/processor.h | 1 +
> > > arch/x86/kernel/cpu/amd.c | 19 +++++++++++++++++--
> > > 2 files changed, 18 insertions(+), 2 deletions(-)
> >
> > Btw, this needs an ACK from a tip person if it goes through the hwmon
> > tree.
>
> Looks good to me in theory.
>
> I suspect we might want to factor the 'compute unit' logic out a bit more if usage
> becomes more widespread - but right now it's hwmon drivers only,right?

So let me withdraw my ack: the much more important question that I missed first
time around, why is this reporting feature living in hwmon, not in perf? We have
energy reporting facilities in perf that this should be synced to.

Thanks,

Ingo