From: Darren Hart <dvhart@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Chen Yu <yu.c.chen@intel.com>,
akpm@linux-foundation.org, arnd@arndb.de,
gregkh@linuxfoundation.org, mchehab@osg.samsung.com,
davem@davemloft.net, jslaby@suse.com, tj@kernel.org,
rjw@rjwysocki.net, rui.zhang@intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons
Date: Fri, 28 Aug 2015 10:56:45 -0700 [thread overview]
Message-ID: <20150828175645.GC33809@vmdeb7> (raw)
In-Reply-To: <1440590641.2670.187.camel@perches.com>
On Wed, Aug 26, 2015 at 05:04:01AM -0700, Joe Perches wrote:
> On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote:
> > On Tue, Aug 18, 2015 at 11:30:25PM +0800, Chen Yu wrote:
> > > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design
> > > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can
> > > not detect these buttons on it. According to bios implementation,
> > > Surface Pro 3 encapsulates these buttons in a device named "VGBI",
> > > with _HID "MSHW0028". When any of the buttons is pressed, a specify
> > > ACPI notification code for this button will be delivered to "VGBI". For
> > > example, if power button is pressed down, ACPI notification code of 0xc6
> > > will be sent by Notify(VGBI, 0xc6).
> []
> > Joe, you provided a lot of review, are you happy with this version?
>
> It looks fine.
>
> Thanks for picking the other little nits too Darren.
This is not queued for next.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-08-28 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 15:30 [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons Chen Yu
2015-08-26 7:22 ` Darren Hart
2015-08-26 12:04 ` Joe Perches
2015-08-28 17:56 ` Darren Hart [this message]
2015-09-01 17:30 ` Josh Boyer
2015-09-03 19:19 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828175645.GC33809@vmdeb7 \
--to=dvhart@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tj@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).