From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Ingo Molnar" <mingo@kernel.org>, "Huang Rui" <ray.huang@amd.com>,
"Borislav Petkov" <bp@suse.de>, "Jean Delvare" <jdelvare@suse.de>,
"Guenter Roeck" <linux@roeck-us.net>,
"Andy Lutomirski" <luto@amacapital.net>,
"Andreas Herrmann" <herrmann.der.user@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Len Brown" <lenb@kernel.org>,
"John Stultz" <john.stultz@linaro.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
x86@kernel.org,
"Andreas Herrmann" <herrmann.der.user@googlemail.com>,
"Aravind Gopalakrishnan" <Aravind.Gopalakrishnan@amd.com>,
"Fengguang Wu" <fengguang.wu@intel.com>,
"Aaron Lu" <aaron.lu@intel.com>, "Tony Li" <tony.li@amd.com>
Subject: Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit
Date: Mon, 31 Aug 2015 10:38:21 +0200 [thread overview]
Message-ID: <20150831083821.GE16853@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150830155322.GA26370@nazgul.tnic>
On Sun, Aug 30, 2015 at 05:53:22PM +0200, Borislav Petkov wrote:
> On Sat, Aug 29, 2015 at 11:19:14AM +0200, Ingo Molnar wrote:
> > So let me withdraw my ack: the much more important question that I
> > missed first time around, why is this reporting feature living in
> > hwmon, not in perf? We have energy reporting facilities in perf that
> > this should be synced to.
>
> Because there's already fam15h_power driver which is exactly for that.
> Making it part of perf is then a question of cat-ting the same sysfs
> file twice, at the beginning and at the end of the trace, which is
> trivial.
That don't make sense.
Looking at the BKDG Fam 15h 60h-6Fh these MSRs are per compute unit.
This means you can do much finer grained measurements than system wide
-- which is all hwmon seems capable of.
Not to mention the proposed code is horrible, who in their right mind
does two rdmsrl_safe_on_cpu() back to back.
next prev parent reply other threads:[~2015-08-31 8:39 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 8:07 [PATCH 00/15] hwmon, fam15h_power: introduce an accumulated power reporting algorithm Huang Rui
2015-08-27 8:07 ` [PATCH 01/15] hwmon, fam15h_power: add support for AMD Carrizo Huang Rui
2015-08-27 14:35 ` Guenter Roeck
2015-08-27 8:07 ` [PATCH 02/15] hwmon, fam15h_power: rename fam15h_power_is_internal_node0 function Huang Rui
2015-08-27 14:35 ` Guenter Roeck
2015-08-27 8:07 ` [PATCH 03/15] hwmon, fam15h_power: refactor attributes for dynamically added Huang Rui
2015-08-27 14:46 ` Guenter Roeck
2015-08-28 10:05 ` Huang Rui
2015-08-27 8:07 ` [PATCH 04/15] hwmon, fam15h_power: update running_avg_capture bit field to 28 Huang Rui
2015-08-27 14:48 ` Guenter Roeck
2015-08-27 8:07 ` [PATCH 05/15] hwmon, fam15h_power: enable power1_input on AMD Carrizo Huang Rui
2015-08-27 14:50 ` Guenter Roeck
2015-08-27 8:07 ` [PATCH 06/15] hwmon, fam15h_power: add documentation for new processors support Huang Rui
2015-08-27 14:51 ` Guenter Roeck
2015-08-27 8:07 ` [PATCH 07/15] hwmon, fam15h_power: add ratio of Tsample to the PTSC period Huang Rui
2015-08-27 14:54 ` Guenter Roeck
2015-08-27 8:07 ` [PATCH 08/15] hwmon, fam15h_power: add max compute unit accumulated power Huang Rui
2015-08-27 14:56 ` Guenter Roeck
2015-08-27 8:07 ` [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit Huang Rui
2015-08-27 17:27 ` Guenter Roeck
2015-08-28 10:28 ` Huang Rui
2015-08-28 6:48 ` Borislav Petkov
2015-08-28 8:00 ` Guenter Roeck
2015-08-28 8:04 ` Ingo Molnar
2015-08-28 8:56 ` Borislav Petkov
2015-08-28 10:18 ` Huang Rui
2015-08-29 9:19 ` Ingo Molnar
2015-08-30 15:53 ` Borislav Petkov
2015-08-31 8:38 ` Peter Zijlstra [this message]
2015-08-31 13:26 ` Guenter Roeck
2015-08-31 13:38 ` Peter Zijlstra
2015-08-31 13:53 ` Guenter Roeck
2015-08-31 14:57 ` Peter Zijlstra
2015-08-31 15:11 ` Guenter Roeck
2015-08-31 16:06 ` Borislav Petkov
2015-08-31 16:19 ` Guenter Roeck
2015-08-31 20:44 ` Peter Zijlstra
2015-08-31 21:24 ` Guenter Roeck
2015-09-01 15:56 ` Borislav Petkov
2015-09-01 16:06 ` Guenter Roeck
2015-08-27 8:07 ` [PATCH 10/15] hwmon, fam15h_power: add compute unit accumulated power Huang Rui
2015-08-28 8:03 ` Ingo Molnar
2015-08-28 10:42 ` Huang Rui
2015-08-27 8:07 ` [PATCH 11/15] hwmon, fam15h_power: add ptsc counter value for " Huang Rui
2015-08-27 8:07 ` [PATCH 12/15] hwmon, fam15h_power: introduce a cpu accumulated power reporting algorithm Huang Rui
2015-08-27 17:30 ` Guenter Roeck
2015-08-28 10:45 ` Huang Rui
2015-08-28 14:05 ` Guenter Roeck
2015-08-31 4:16 ` Huang Rui
2015-08-31 4:30 ` Guenter Roeck
2015-08-31 13:11 ` Huang Rui
2015-08-31 13:25 ` Peter Zijlstra
2015-08-31 14:59 ` Peter Zijlstra
2015-08-27 8:07 ` [PATCH 13/15] hwmon, fam15h_power: add documentation for previous TDP reporting Huang Rui
2015-08-27 8:07 ` [PATCH 14/15] hwmon, fam15h_power: add documentation for accumulated power algorithm Huang Rui
2015-08-27 8:07 ` [PATCH 15/15] MAINTAINERS: change the maintainer of fam15h_power driver Huang Rui
2015-08-29 16:33 ` [15/15] " Guenter Roeck
2015-08-31 1:11 ` Huang Rui
2015-08-31 15:19 ` Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831083821.GE16853@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=aaron.lu@intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=herrmann.der.user@gmail.com \
--cc=herrmann.der.user@googlemail.com \
--cc=jdelvare@suse.de \
--cc=john.stultz@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=ray.huang@amd.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.li@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox