public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Kirill Tkhai <ktkhai@odin.com>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
	Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks
Date: Mon, 31 Aug 2015 15:37:03 +0200	[thread overview]
Message-ID: <20150831133703.GL19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <55E444C8.3020402@odin.com>


I made that two patches, like:

---
Subject: perf: Delete PF_EXITING checks from perf_cgroup_exit() callback
From: Kirill Tkhai <ktkhai@odin.com>
Date: Mon, 31 Aug 2015 15:12:56 +0300

cgroup_exit() is not called from copy_process() after commit:

  e8604cb43690 ("cgroup: fix spurious lockdep warning in cgroup_exit()")

from do_exit(). So this check is useless and the comment is obsolete.

Signed-off-by: Kirill Tkhai <ktkhai@odin.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: http://lkml.kernel.org/r/55E444C8.3020402@odin.com
---
 kernel/events/core.c |    8 --------
 1 file changed, 8 deletions(-)

--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgro
 			     struct cgroup_subsys_state *old_css,
 			     struct task_struct *task)
 {
-	/*
-	 * cgroup_exit() is called in the copy_process() failure path.
-	 * Ignore this case since the task hasn't ran yet, this avoids
-	 * trying to poke a half freed task state from generic code.
-	 */
-	if (!(task->flags & PF_EXITING))
-		return;
-
 	task_function_call(task, __perf_cgroup_move, task);
 }
 

  reply	other threads:[~2015-08-31 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 11:49 [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks Kirill Tkhai
2015-08-31 11:53 ` Peter Zijlstra
2015-08-31 12:12   ` Kirill Tkhai
2015-08-31 13:37     ` Peter Zijlstra [this message]
2015-09-13 11:01     ` [tip:sched/core] sched/core: Delete PF_EXITING checks from cpu_cgroup_exit() callback tip-bot for Kirill Tkhai
2015-09-13 11:09     ` [tip:perf/core] perf/core: Delete PF_EXITING checks from perf_cgroup_exit() callback tip-bot for Kirill Tkhai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150831133703.GL19282@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ktkhai@odin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox