From: Kent Overstreet <kent.overstreet@gmail.com>
To: Jens Axboe <axboe@fb.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] bcache revert
Date: Mon, 31 Aug 2015 11:53:05 -0800 [thread overview]
Message-ID: <20150831195305.GA2822@kmo-pixel> (raw)
In-Reply-To: <55E4AE1A.1040909@fb.com>
On Mon, Aug 31, 2015 at 01:42:18PM -0600, Jens Axboe wrote:
> On 08/31/2015 01:29 PM, Kent Overstreet wrote:
> >On Mon, Aug 31, 2015 at 01:14:07PM -0600, Jens Axboe wrote:
> >>On 08/31/2015 01:00 PM, Kent Overstreet wrote:
> >>>Linus, please pull; this reverts a patch from Jens that was committed without
> >>>CCing be or being mailed out to any of the lists. Said patch wasn't in any way a
> >>>functional change and is something that damn well should have been discussed.
> >>>
> >>>Jens - what the goddamn fuck!? You've never touched the bcache code until now,
> >>>and when you finally get interested this is what you do!?
> >>>
> >>>While I am sympathetic to the arguments in favor of your patch, there _are_ some
> >>>damn good reasons I did it the way I did. If you want to have that discussion,
> >>>feel free to mail your patch out again after the revert.
> >>
> >>The patch was part of a larger series that I was working on, and I just
> >>wanted to flush out that dependency. Christoph review and acked it, it was
> >>by no means a sneaking in of a patch.
> >
> >I didn't see it until I went to rebase bcachefs onto 4.2 this morning. I triple
> >checked; this patch is not in any mailing list archive. And you certainly didn't
> >try to contact me. How is that _not_ sneaking it in?
>
> It's a simple cleanup patch, against a dormant driver. It was reviewed by
> Christoph, which is as good as it gets. Yes, it should have been posted, but
> it's not like we are talking about a rewrite or anything of that magnitude.
> You're grossly overreacting. I would do it again.
Look, you've had your own periods as an unavailable maintainer so I wouldn't
throw stones - and it's no secret that I'm still working on bcache.
Really, as long as you think it's ok to commit patches without CCing the mailing
list _or_ the maintainer, then fuck you. I wouldn't do that to you and I don't
know anyone else who would, so as long as that's your attitude about it there's
really nothing to discuss.
next prev parent reply other threads:[~2015-08-31 19:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 19:00 [GIT PULL] bcache revert Kent Overstreet
2015-08-31 19:14 ` Jens Axboe
2015-08-31 19:29 ` Kent Overstreet
2015-08-31 19:42 ` Jens Axboe
2015-08-31 19:53 ` Kent Overstreet [this message]
2015-08-31 20:06 ` Jens Axboe
2015-08-31 20:17 ` Kent Overstreet
2015-08-31 20:25 ` Jens Axboe
2015-08-31 20:42 ` Kent Overstreet
2015-08-31 20:47 ` Jens Axboe
2015-08-31 20:57 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831195305.GA2822@kmo-pixel \
--to=kent.overstreet@gmail.com \
--cc=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox