From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <agross@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs
Date: Mon, 31 Aug 2015 22:06:44 -0700 [thread overview]
Message-ID: <20150901050644.GD13472@usrtlx11787.corpusers.net> (raw)
In-Reply-To: <1441071594-15941-4-git-send-email-sboyd@codeaurora.org>
On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote:
> The smd structures are always in little endian, but the smd
> driver is not capable of being used on big endian CPUs. Annotate
> the little endian data members and update the code to do the
> proper byte swapping.
>
I think this looks good, but I think it would be better to reference
the 8-bit entries of the info struct as "flags" rather than INFO8s.
Could you please change the name of the macros to
{G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to
follow?
Regards,
Bjorn
next prev parent reply other threads:[~2015-09-01 5:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 1:39 [PATCH 0/3] qcom smd big endian support Stephen Boyd
2015-09-01 1:39 ` [PATCH 1/3] soc: qcom: smd: Represent channel layout in structures Stephen Boyd
2015-09-01 4:55 ` Bjorn Andersson
2015-09-01 17:51 ` Stephen Boyd
2015-09-01 1:39 ` [PATCH 2/3] soc: qcom: smd: Use __iowrite32_copy() instead of open-coding it Stephen Boyd
2015-09-01 4:59 ` Bjorn Andersson
2015-09-01 18:03 ` Stephen Boyd
2015-09-01 20:30 ` Stephen Boyd
2015-09-01 1:39 ` [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs Stephen Boyd
2015-09-01 5:06 ` Bjorn Andersson [this message]
2015-09-01 18:04 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901050644.GD13472@usrtlx11787.corpusers.net \
--to=bjorn.andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox