From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755431AbbIAIvm (ORCPT ); Tue, 1 Sep 2015 04:51:42 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:56444 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741AbbIAIvi (ORCPT ); Tue, 1 Sep 2015 04:51:38 -0400 Date: Tue, 1 Sep 2015 09:29:43 +0100 From: Charles Keepax To: Sudip Mukherjee CC: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH] ASoC: wm0010: fix memory leak Message-ID: <20150901082943.GA15505@ck-lbox> References: <1441086245-14732-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1441086245-14732-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-09-01_03:2015-08-31,2015-09-01,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1508030000 definitions=main-1509010151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 01, 2015 at 11:14:05AM +0530, Sudip Mukherjee wrote: > We were aborting if the kzalloc of img_swap fails but without freeing the > already allocated out. Similarly we were aborting if spi_sync fails > without releasing out and img_swap. > > Signed-off-by: Sudip Mukherjee > --- Acked-by: Charles Keepax Thanks, Charles