From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Taku Izumi <izumi.taku@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, mingo@redhat.com, acme@kernel.org,
hpa@zytor.com, x86@kernel.org, jolsa@redhat.com
Subject: Re: [PATCH v2][RESEND] perf, x86: Fix multi-segment problem of perf_event_intel_uncore
Date: Tue, 1 Sep 2015 13:39:39 +0200 [thread overview]
Message-ID: <20150901113939.GS19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150901113147.GA11161@gmail.com>
On Tue, Sep 01, 2015 at 01:31:47PM +0200, Ingo Molnar wrote:
>
> * Peter Zijlstra <peterz@infradead.org> wrote:
>
> > +struct __find_pci2phy(int segment)
> > +{
> > + struct pci2phy_map *map;
> > +
> > + lockdep_assert_held(&pci2phy_map_lock);
> > +
> > + list_for_each_entry(map, &pci2phy_map_head, list) {
> > + if (map->segment == segment)
> > + return map;
> > + }
> > +
> > + map = kmalloc(sizeof(struct pci2phy_map), GFP_ATOMIC);
>
> I really don't think we should be adding new GFP_ATOMIC allocations whenever it
> can be avoided.
I tend to agree, it makes the whole thing rather fragile...
prev parent reply other threads:[~2015-09-01 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 10:54 [PATCH v2][RESEND] perf, x86: Fix multi-segment problem of perf_event_intel_uncore Taku Izumi
2015-09-01 11:15 ` Peter Zijlstra
2015-09-01 11:31 ` Ingo Molnar
2015-09-01 11:39 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901113939.GS19282@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=hpa@zytor.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox