From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753884AbbIAPqO (ORCPT ); Tue, 1 Sep 2015 11:46:14 -0400 Received: from muru.com ([72.249.23.125]:47997 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbbIAPqM (ORCPT ); Tue, 1 Sep 2015 11:46:12 -0400 Date: Tue, 1 Sep 2015 08:46:09 -0700 From: Tony Lindgren To: Frans Klaver Cc: Frans Klaver , Russell King , David Binderman , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: omap2: vc: fix 'or' always true warning Message-ID: <20150901154609.GK4215@atomide.com> References: <1440756632-14043-1-git-send-email-frans.klaver@xsens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440756632-14043-1-git-send-email-frans.klaver@xsens.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frans Klaver [150828 03:14]: > From: Frans Klaver > > Fix the warning: > arch/arm/mach-omap2/vc.c:302:47: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op] > > As we're toggling both CLKREQ and OFFMODE, we should also be checking > OFFMODE. > > Signed-off-by: Frans Klaver Thanks apppying into omap-for-v4.3/fixes. Tony > --- > arch/arm/mach-omap2/vc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c > index 076fd20d7e5a..807bc79e3e3d 100644 > --- a/arch/arm/mach-omap2/vc.c > +++ b/arch/arm/mach-omap2/vc.c > @@ -300,7 +300,7 @@ static void __init omap3_vc_init_pmic_signaling(struct voltagedomain *voltdm) > > val = voltdm->read(OMAP3_PRM_POLCTRL_OFFSET); > if (!(val & OMAP3430_PRM_POLCTRL_CLKREQ_POL) || > - (val & OMAP3430_PRM_POLCTRL_CLKREQ_POL)) { > + (val & OMAP3430_PRM_POLCTRL_OFFMODE_POL)) { > val |= OMAP3430_PRM_POLCTRL_CLKREQ_POL; > val &= ~OMAP3430_PRM_POLCTRL_OFFMODE_POL; > pr_debug("PM: fixing sys_clkreq and sys_off_mode polarity to 0x%x\n", > -- > 2.3.4 >