From: Mark Rutland <mark.rutland@arm.com>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"ddaney@caviumnetworks.com" <ddaney@caviumnetworks.com>,
suzuki.poulose@arm.com
Subject: Re: [PATCH 1/2] arm64: cpufeature.h: resolve hidden header dependencies
Date: Tue, 1 Sep 2015 17:02:58 +0100 [thread overview]
Message-ID: <20150901160258.GA16430@leverpostej> (raw)
In-Reply-To: <1441118472-3513-2-git-send-email-ynorov@caviumnetworks.com>
On Tue, Sep 01, 2015 at 03:41:11PM +0100, Yury Norov wrote:
> Functions implemented in cpufeature.h depend on some headers, but
> cpufeature.h does not include them. This may cause build failure if
> cpufeature.h user does not include that headers by itself. (Like it
> happens in next patch of this series.)
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> ---
> arch/arm64/include/asm/cpufeature.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
> index c104421..20cdc26 100644
> --- a/arch/arm64/include/asm/cpufeature.h
> +++ b/arch/arm64/include/asm/cpufeature.h
> @@ -30,6 +30,11 @@
>
> #ifndef __ASSEMBLY__
>
> +#include <linux/bitmap.h>
We're also missing <linux/compiler.h> for the __attribute_const__ on
cpuid_feature_extract_field.
> +#include <linux/log2.h>
The cpu_feature macro using ilog2 is prior to the __ASSEMBLY__ guard.
Given it cannot be used by assembly, I think it should also be pulled
under the guard, or removed as it doesn't appear to be used anyway
(which would remove the need for this include).
Otherwise this looks good to me.
Thanks,
Mark.
> +#include <linux/printk.h>
> +#include <linux/types.h>
> +
> struct arm64_cpu_capabilities {
> const char *desc;
> u16 capability;
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2015-09-01 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 14:41 [PATCH 0/2] arm64: introduce run-time detection of aarch32 support Yury Norov
2015-09-01 14:41 ` [PATCH 1/2] arm64: cpufeature.h: resolve hidden header dependencies Yury Norov
2015-09-01 16:02 ` Mark Rutland [this message]
2015-09-01 14:41 ` [PATCH 2/2] arm64: don't load 32-bit binaries if platform has no aarch32_el0 Yury Norov
2015-09-01 16:04 ` Mark Rutland
2015-09-01 17:41 ` Suzuki K. Poulose
2015-09-01 17:44 ` Yury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901160258.GA16430@leverpostej \
--to=mark.rutland@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox