From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754800AbbIAShD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Sep 2015 14:37:03 -0400
Received: from mail.kernel.org ([198.145.29.136]:34422 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752808AbbIAShB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Sep 2015 14:37:01 -0400
Date: Tue, 1 Sep 2015 15:36:57 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, jolsa@kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Always use non inlined file name for srcfile
Message-ID: <20150901183657.GG29821@kernel.org>
References: <1441131102-28331-1-git-send-email-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1441131102-28331-1-git-send-email-andi@firstfloor.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Sep 01, 2015 at 11:11:42AM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> When profiling the kernel with srcfile it's common to "get
> stuck" in include. For example a lot of code uses current
> or other inlines, so they get accounted to some random
> include file. This is not very useful as a high level
> categorization.

Cool idea :-)
 
> For example just profiling the idle loop usually shows
> mostly inlines, so you never see the actual cpuidle file.
> @@ -170,6 +171,15 @@ static int addr2line(const char *dso_name, u64 addr,
>  
>  	bfd_map_over_sections(a2l->abfd, find_address_in_section, a2l);
>  
> +	if (a2l->found && unwind_inlines) {
> +		bool found;
> +
> +		do {
> +			found = bfd_find_inliner_info(a2l->abfd, &a2l->filename,
> +						      &a2l->funcname, &a2l->line);
> +		} while (found);
> +	}

Why not the so much simpler:

		while (bfd_find_inliner_info(...));

But other than that, wouldn't be better to put an upper limit on this?

Say, 1024 levels of unwinding to avoid tripping in some bfd lib bug that
could make this function always return true and make addr2line get stuck
in an infinite loop?

- Arnaldo