Re: [PATCH] perf, tools: Always use non inlined file name for srcfile

Arnaldo Carvalho de Melo
2015-09-01T19:21:50Z

Em Tue, Sep 01, 2015 at 11:48:39AM -0700, Andi Kleen escreveu:
> On Tue, Sep 01, 2015 at 03:36:57PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Sep 01, 2015 at 11:11:42AM -0700, Andi Kleen escreveu:
> > > From: Andi Kleen <ak@linux.intel.com>
> > >
> > > When profiling the kernel with srcfile it's common to "get
> > > stuck" in include. For example a lot of code uses current
> > > or other inlines, so they get accounted to some random
> > > include file. This is not very useful as a high level
> > > categorization.
> >
> > Cool idea :-)
>
> Yes.
>
> It would be also nice to use this information for unwinding
> (so to show the inline stack as part of the call graph)

Yes, agreed.

> > Why not the so much simpler:
> >
> > while (bfd_find_inliner_info(...));
> >
> > But other than that, wouldn't be better to put an upper limit on this?
> >
> > Say, 1024 levels of unwinding to avoid tripping in some bfd lib bug that
> > could make this function always return true and make addr2line get stuck
> > in an infinite loop?
>
> Done. I sent a v2.

Thanks, I applied v2.

- Arnaldo