From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751903AbbIAUTW (ORCPT ); Tue, 1 Sep 2015 16:19:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32807 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbbIAUTU (ORCPT ); Tue, 1 Sep 2015 16:19:20 -0400 Date: Tue, 1 Sep 2015 17:19:17 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: mingo@kernel.org, ast@plumgrid.com, linux-kernel@vger.kernel.org, lizefan@huawei.com, pi3orama@163.com, He Kuang , Brendan Gregg , Daniel Borkmann , David Ahern , Jiri Olsa , Kaixu Xia , Masami Hiramatsu , Namhyung Kim , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH 27/31] perf record: Support custom vmlinux path Message-ID: <20150901201917.GF22331@redhat.com> References: <1440822125-52691-1-git-send-email-wangnan0@huawei.com> <1440822125-52691-28-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440822125-52691-28-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Aug 29, 2015 at 04:22:01AM +0000, Wang Nan escreveu: > From: He Kuang > > Make perf-record command support --vmlinux option if BPF_PROLOGUE is on. Ok, this should be supported, i.e. letting the user specify a vmlinux path to use. But it shouldn't be _required_, i.e. we have things like vmlinux_path to try to find it in well known places. Right now it will search for it in the process of trying to load its symtab, but I think we should have a function that tries to find a vmlinux that matches the build-id of the running kernel, for things that want to have access directly to the ELF file with debuginfo without having to load the symtab in a struct dso, etc. I'll look at the next patches to check how you make use of this info... - Arnaldo > 'perf record' needs vmlinux as the source of DWARF info to generate > prologue for BPF programs, so path of vmlinux should be specified. > > Short name 'k' has been taken by 'clockid'. This patch skips the short > option name and use '--vmlinux' for vmlinux path. > > Signed-off-by: He Kuang > Signed-off-by: Wang Nan > Cc: Alexei Starovoitov > Cc: Brendan Gregg > Cc: Daniel Borkmann > Cc: David Ahern > Cc: He Kuang > Cc: Jiri Olsa > Cc: Kaixu Xia > Cc: Masami Hiramatsu > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra > Cc: Zefan Li > Cc: pi3orama@163.com > Cc: Arnaldo Carvalho de Melo > Link: http://lkml.kernel.org/n/1436445342-1402-38-git-send-email-wangnan0@huawei.com > --- > tools/perf/builtin-record.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 212718c..8eb39d5 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -1100,6 +1100,10 @@ struct option __record_options[] = { > "clang binary to use for compiling BPF scriptlets"), > OPT_STRING(0, "clang-opt", &llvm_param.clang_opt, "clang options", > "options passed to clang when compiling BPF scriptlets"), > +#ifdef HAVE_BPF_PROLOGUE > + OPT_STRING(0, "vmlinux", &symbol_conf.vmlinux_name, > + "file", "vmlinux pathname"), > +#endif > #endif > OPT_END() > }; > -- > 2.1.0