From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbbIAVn4 (ORCPT ); Tue, 1 Sep 2015 17:43:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41731 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbbIAVnz (ORCPT ); Tue, 1 Sep 2015 17:43:55 -0400 Date: Tue, 1 Sep 2015 18:43:50 -0300 From: Arnaldo Carvalho de Melo To: pi3orama Cc: Wang Nan , "mingo@kernel.org" , "ast@plumgrid.com" , "linux-kernel@vger.kernel.org" , "lizefan@huawei.com" , He Kuang , Brendan Gregg , Daniel Borkmann , David Ahern , Jiri Olsa , Kaixu Xia , Masami Hiramatsu , Namhyung Kim , Paul Mackerras , Peter Zijlstra , acme@kernel.org Subject: Re: [PATCH 21/31] perf tools: Move linux/filter.h to tools/include Message-ID: <20150901214350.GI22331@redhat.com> References: <1440822125-52691-1-git-send-email-wangnan0@huawei.com> <1440822125-52691-22-git-send-email-wangnan0@huawei.com> <20150901193959.GB22331@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Sep 02, 2015 at 05:08:27AM +0800, pi3orama escreveu: > 发自我的 iPhone > > 在 2015年9月2日，上午3:39，Arnaldo Carvalho de Melo 写道： > > Em Sat, Aug 29, 2015 at 04:21:55AM +0000, Wang Nan escreveu: > >> From: He Kuang > >> This patch moves filter.h from include/linux/kernel.h to > > I said that before: this is not moving anything, it is copying :-) > >> tools/include/linux/filter.h to enable other libraries use macros in > >> it, like libbpf which will be introduced by further patches. Currenty, > >> the moved filter.h only contains the useful macros needed by libbpf > >> for not introducing too much dependence. > >> MANIFEST is also updated for 'make perf-*-src-pkg'. > > So, I did a: > > > > $ diff -u include/linux/filter.h tools/include/linux/filter.h > > > > And noticed these: > > > > -/* Endianess conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */ > > +/* Endianness conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */ > > > > -/* Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32 */ > > +/* Short form of mov based on type, > > + * BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32 > > + */ > > > > -/* Conditional jumps against registers, if (dst_reg 'op' src_reg) goto pc + off16 */ > > +/* Conditional jumps against registers, > > + * if (dst_reg 'op' src_reg) goto pc + off16 > > + */ > > > > -/* Conditional jumps against immediates, if (dst_reg 'op' imm32) goto pc + off16 */ > > +/* Conditional jumps against immediates, > > + * if (dst_reg 'op' imm32) goto pc + off16 > > + */ > > > > ------------------------------------------------------------------ > > > > I think these changes are made after we made this patch. Don't think so, for instance, this one: /* Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32 */ [acme@zoo linux]$ git log -p include/linux/filter.h | grep 'Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32' /* Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32 */ /* Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32 */ /* Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32 */ +/* Short form of mov based on type, BPF_X: dst_reg = src_reg, BPF_K: dst_reg = imm32 */ [acme@zoo linux]$ Was introduced, in just one line, and never again touched, just appearing as context in subsequent patches. I bet this was related to checkpatch.pl complaining it has more than 80 lines ;-\ Ditto for: [acme@zoo linux]$ git log -p include/linux/filter.h | grep 'Endiann\?ess conversion' /* Endianess conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */ /* Endianess conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */ +/* Endianess conversion, cpu_to_{l,b}e(), {l,b}e_to_cpu() */ [acme@zoo linux]$ > Thank you for checking it. np. - Arnaldo