From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754514AbbIAWsL (ORCPT ); Tue, 1 Sep 2015 18:48:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47544 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbbIAWsJ (ORCPT ); Tue, 1 Sep 2015 18:48:09 -0400 Date: Tue, 1 Sep 2015 15:48:07 -0700 From: Stephen Boyd To: Viresh Kumar Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, nm@ti.com, khilman@linaro.org, Greg Kroah-Hartman , Len Brown , open list , Pavel Machek Subject: Re: [PATCH V2 Resend 1/5] PM / OPP: reuse of_parse_phandle() Message-ID: <20150901224807.GA21112@codeaurora.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01, Viresh Kumar wrote: > We already have a better API to get the opp descriptor block's node from > cpu-node. Lets reuse that instead of creating our own routines for the > same stuff. That cleans the code a lot. > > This also kills a check we had earlier (as we are using the generic API > now). Earlier we used to check if the operating-points-v2 property > contained multiple phandles instead of a single phandle. > > Killing this check isn't an issue because, we only parse the first entry > with of_parse_phandle(). So, if a user passes multiple phandles, its > really his problem :) > > Signed-off-by: Viresh Kumar > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project