From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754627AbbIAWvU (ORCPT ); Tue, 1 Sep 2015 18:51:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47721 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754601AbbIAWvR (ORCPT ); Tue, 1 Sep 2015 18:51:17 -0400 Date: Tue, 1 Sep 2015 15:51:15 -0700 From: Stephen Boyd To: Viresh Kumar Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, nm@ti.com, khilman@linaro.org, Anand Moon , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Len Brown , open list , Pavel Machek Subject: Re: [PATCH V2 Resend 3/5] PM / OPP: Move opp core to its own directory Message-ID: <20150901225115.GB21112@codeaurora.org> References: <54ff6f4e8fe495d9a859a7a7aa61ac2e79f08551.1441083292.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54ff6f4e8fe495d9a859a7a7aa61ac2e79f08551.1441083292.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01, Viresh Kumar wrote: > OPP code is expanding and is already present in multiple directories > (cpufreq and power). Lets move it to its own directory, to manage it > better. > > This also moves/renames the cpufreq_opp file to cpu.c, as it will > contain helpers for cpu device. Its not just about cpufreq, other > frameworks can use OPPs as well. > > Signed-off-by: Viresh Kumar Reviewed-by: Stephen Boyd > diff --git a/drivers/base/power/opp/Makefile b/drivers/base/power/opp/Makefile > new file mode 100644 > index 000000000000..33c1e18c41a4 > --- /dev/null > +++ b/drivers/base/power/opp/Makefile > @@ -0,0 +1,2 @@ > +ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG It's odd that we use CONFIG_DEBUG_DRIVER here when that's talking about debugging the driver core. I wonder why this wouldn't be some OPP specific debug config option instead. But that was already there before so this topic is for another patch. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project