From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752406AbbIBGDO (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Sep 2015 02:03:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34682 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752269AbbIBGDK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Sep 2015 02:03:10 -0400
Date: Wed, 2 Sep 2015 08:03:08 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "ak@linux.intel.com" <ak@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 3/3] perf,test: test cpu topology
Message-ID: <20150902060308.GD1978@krava.brq.redhat.com>
References: <1441115893-22006-1-git-send-email-kan.liang@intel.com>
 <1441115893-22006-3-git-send-email-kan.liang@intel.com>
 <20150901222952.GB12722@kernel.org>
 <37D7C6CF3E00A74B8858931C1DB2F077018F5D2E@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018F5D2E@SHSMSX103.ccr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 01, 2015 at 11:25:10PM +0000, Liang, Kan wrote:
> 
> 
> > 
> > Em Tue, Sep 01, 2015 at 09:58:13AM -0400, Kan Liang escreveu:
> > > From: Jiri Olsa <jolsa@kernel.org>
> > >
> > > This patch test cpu core_id and socket_id which are stored in perf_env.
> > >
> > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > Signed-off-by: Kan Liang <kan.liang@intel.com>
> > > ---
> > >
> > > Changes since jirka's original version
> > >  - Use pr_debug to replace fprintf
> > >  - Add date_size to avoid warning
> > >  - Introduce cpu_map, and compare core_id and socket_id
> > >    between cpu_map and perf_env
> > 
> > Humm, two questions:
> > 
> > Since you changed it that much, wouldn't be better to give you the
> > authorship while still giving credit to Jiri for the original version?
> > Something like:
> > 
> > Based-on-a-patch-by: Jiri Olsa
> 
> Jiri, are you OK with that?

yep

> 
> > 
> > [acme@zoo linux]$ git log | grep Based-on-patch-by: | wc -l
> > 61
> > [acme@zoo linux]$ git log | grep Based-on-a-patch-by: | wc -l
> > 4
> > [acme@zoo linux]$
> > 
> > But then you need to resubmit this anyway, as you forgot to do the:
> > 
> >  git add tools/perf/tests/topology.c
> 
> Ah... My bad. :(
> 
> I will resubmit the patch then.

I'll review new version

jirka