From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857AbbIBIaB (ORCPT ); Wed, 2 Sep 2015 04:30:01 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37854 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbbIBI37 (ORCPT ); Wed, 2 Sep 2015 04:29:59 -0400 Date: Wed, 2 Sep 2015 10:29:55 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Byungchul Park , linux-kernel@vger.kernel.org, yuyang.du@intel.com, efault@gmx.de, tglx@linutronix.de Subject: Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq Message-ID: <20150902082955.GA9387@gmail.com> References: <1440069720-27038-1-git-send-email-byungchul.park@lge.com> <1440069720-27038-6-git-send-email-byungchul.park@lge.com> <20150820113516.GJ24261@byungchulpark-X58A-UD3R> <20150831152138.GO19282@twins.programming.kicks-ass.net> <20150901002849.GA30881@byungchulpark-X58A-UD3R> <20150901150343.GT19282@twins.programming.kicks-ass.net> <20150902023315.GA6455@byungchulpark-X58A-UD3R> <20150902081456.GQ16853@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150902081456.GQ16853@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Wed, Sep 02, 2015 at 11:33:15AM +0900, Byungchul Park wrote: > > +++ b/kernel/sched/fair.c > > @@ -7920,14 +7920,14 @@ prio_changed_fair(struct rq *rq, struct task_struct *p, int oldprio) > > > > static inline bool vruntime_normalized(struct task_struct *p) > > { > > struct sched_entity *se = &p->se; > > > > /* > > + * In both TASK_ON_RQ_QUEUED case and TASK_ON_RQ_MIGRATING case, s/ In both the TASK_ON_RQ_QUEUED and TASK_ON_RQ_MIGRATING cases, > > + * the dequeue_entity(.flags=0) will already have normalized the > > + * vruntime. Thanks, Ingo