* [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers
@ 2015-08-27 15:04 Luis de Bethencourt
2015-09-02 9:21 ` Lee Jones
2015-10-15 0:44 ` Eric Anholt
0 siblings, 2 replies; 4+ messages in thread
From: Luis de Bethencourt @ 2015-08-27 15:04 UTC (permalink / raw)
To: linux-kernel
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Stephen Warren, Lee Jones, Wolfram Sang, alsa-devel,
linux-rpi-kernel, linux-kernel
These platform drivers have a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
sound/soc/bcm/bcm2835-i2s.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
index 03fa1cb..8c435be 100644
--- a/sound/soc/bcm/bcm2835-i2s.c
+++ b/sound/soc/bcm/bcm2835-i2s.c
@@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
{},
};
+MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
+
static struct platform_driver bcm2835_i2s_driver = {
.probe = bcm2835_i2s_probe,
.driver = {
--
2.4.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers
2015-08-27 15:04 [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers Luis de Bethencourt
@ 2015-09-02 9:21 ` Lee Jones
2015-10-15 0:44 ` Eric Anholt
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2015-09-02 9:21 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Stephen Warren, Wolfram Sang, alsa-devel,
linux-rpi-kernel
On Thu, 27 Aug 2015, Luis de Bethencourt wrote:
> These platform drivers have a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
> sound/soc/bcm/bcm2835-i2s.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Lee Jones <lee@kernel.org>
> diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
> index 03fa1cb..8c435be 100644
> --- a/sound/soc/bcm/bcm2835-i2s.c
> +++ b/sound/soc/bcm/bcm2835-i2s.c
> @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
> {},
> };
>
> +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
> +
> static struct platform_driver bcm2835_i2s_driver = {
> .probe = bcm2835_i2s_probe,
> .driver = {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers
2015-08-27 15:04 [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers Luis de Bethencourt
2015-09-02 9:21 ` Lee Jones
@ 2015-10-15 0:44 ` Eric Anholt
2015-10-15 12:36 ` Luis de Bethencourt
1 sibling, 1 reply; 4+ messages in thread
From: Eric Anholt @ 2015-10-15 0:44 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Stephen Warren, Lee Jones, Wolfram Sang, alsa-devel,
linux-rpi-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
Luis de Bethencourt <luis@debethencourt.com> writes:
> These platform drivers have a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
> sound/soc/bcm/bcm2835-i2s.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
> index 03fa1cb..8c435be 100644
> --- a/sound/soc/bcm/bcm2835-i2s.c
> +++ b/sound/soc/bcm/bcm2835-i2s.c
> @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
> {},
> };
>
> +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
> +
> static struct platform_driver bcm2835_i2s_driver = {
> .probe = bcm2835_i2s_probe,
> .driver = {
> --
It looks like this should go through the asoc tree, but I don't see it
in there.
FWIW, it is also:
Acked-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers
2015-10-15 0:44 ` Eric Anholt
@ 2015-10-15 12:36 ` Luis de Bethencourt
0 siblings, 0 replies; 4+ messages in thread
From: Luis de Bethencourt @ 2015-10-15 12:36 UTC (permalink / raw)
To: Eric Anholt
Cc: linux-kernel, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Stephen Warren, Lee Jones, Wolfram Sang, alsa-devel,
linux-rpi-kernel
On Wed, Oct 14, 2015 at 05:44:46PM -0700, Eric Anholt wrote:
> Luis de Bethencourt <luis@debethencourt.com> writes:
>
> > These platform drivers have a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > ---
> > sound/soc/bcm/bcm2835-i2s.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
> > index 03fa1cb..8c435be 100644
> > --- a/sound/soc/bcm/bcm2835-i2s.c
> > +++ b/sound/soc/bcm/bcm2835-i2s.c
> > @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
> > {},
> > };
> >
> > +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
> > +
> > static struct platform_driver bcm2835_i2s_driver = {
> > .probe = bcm2835_i2s_probe,
> > .driver = {
> > --
>
> It looks like this should go through the asoc tree, but I don't see it
> in there.
>
> FWIW, it is also:
>
> Acked-by: Eric Anholt <eric@anholt.net>
Hi Eric,
Should I resend adding somebody from the asoc tree to the CC?
Thanks for the review,
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-15 12:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-27 15:04 [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers Luis de Bethencourt
2015-09-02 9:21 ` Lee Jones
2015-10-15 0:44 ` Eric Anholt
2015-10-15 12:36 ` Luis de Bethencourt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox