* [PATCH] perf, tools, stat: Quieten failed to read counter message
@ 2015-09-01 22:52 Andi Kleen
2015-09-02 6:07 ` Jiri Olsa
2015-09-08 14:32 ` [tip:perf/core] perf " tip-bot for Andi Kleen
0 siblings, 2 replies; 5+ messages in thread
From: Andi Kleen @ 2015-09-01 22:52 UTC (permalink / raw)
To: acme; +Cc: linux-kernel, jolsa, Andi Kleen
From: Andi Kleen <ak@linux.intel.com>
Since 3b3eb0445 running perf stat on a system without
backend-stalled-cycles spits out ugly warnings by default. Since that is quite
common, make the message a debug message only. We know
anyways that the counter wasn't read by the normal <unsupported>
output.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/builtin-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index d46dbb1..a96fb5c 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
evlist__for_each(evsel_list, counter) {
if (read_counter(counter))
- pr_warning("failed to read counter %s\n", counter->name);
+ pr_debug("failed to read counter %s\n", counter->name);
if (perf_stat_process_counter(&stat_config, counter))
pr_warning("failed to process counter %s\n", counter->name);
--
2.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf, tools, stat: Quieten failed to read counter message
2015-09-01 22:52 [PATCH] perf, tools, stat: Quieten failed to read counter message Andi Kleen
@ 2015-09-02 6:07 ` Jiri Olsa
2015-09-02 12:53 ` Arnaldo Carvalho de Melo
2015-09-08 14:32 ` [tip:perf/core] perf " tip-bot for Andi Kleen
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Olsa @ 2015-09-02 6:07 UTC (permalink / raw)
To: Andi Kleen; +Cc: acme, linux-kernel, jolsa, Andi Kleen
On Tue, Sep 01, 2015 at 03:52:46PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Since 3b3eb0445 running perf stat on a system without
> backend-stalled-cycles spits out ugly warnings by default. Since that is quite
> common, make the message a debug message only. We know
> anyways that the counter wasn't read by the normal <unsupported>
> output.
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/builtin-stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index d46dbb1..a96fb5c 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
>
> evlist__for_each(evsel_list, counter) {
> if (read_counter(counter))
> - pr_warning("failed to read counter %s\n", counter->name);
> + pr_debug("failed to read counter %s\n", counter->name);
>
> if (perf_stat_process_counter(&stat_config, counter))
> pr_warning("failed to process counter %s\n", counter->name);
> --
> 2.4.3
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf, tools, stat: Quieten failed to read counter message
2015-09-02 6:07 ` Jiri Olsa
@ 2015-09-02 12:53 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-02 12:53 UTC (permalink / raw)
To: Jiri Olsa; +Cc: Andi Kleen, linux-kernel, jolsa, Andi Kleen
Em Wed, Sep 02, 2015 at 08:07:20AM +0200, Jiri Olsa escreveu:
> On Tue, Sep 01, 2015 at 03:52:46PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > Since 3b3eb0445 running perf stat on a system without
> > backend-stalled-cycles spits out ugly warnings by default. Since that is quite
> > common, make the message a debug message only. We know
> > anyways that the counter wasn't read by the normal <unsupported>
> > output.
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/core] perf stat: Quieten failed to read counter message
2015-09-01 22:52 [PATCH] perf, tools, stat: Quieten failed to read counter message Andi Kleen
2015-09-02 6:07 ` Jiri Olsa
@ 2015-09-08 14:32 ` tip-bot for Andi Kleen
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Andi Kleen @ 2015-09-08 14:32 UTC (permalink / raw)
To: linux-tip-commits; +Cc: tglx, linux-kernel, acme, jolsa, hpa, ak, mingo
Commit-ID: 245bad8eb45fca36638da53fb0a361397a707001
Gitweb: http://git.kernel.org/tip/245bad8eb45fca36638da53fb0a361397a707001
Author: Andi Kleen <ak@linux.intel.com>
AuthorDate: Tue, 1 Sep 2015 15:52:46 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 2 Sep 2015 16:30:47 -0300
perf stat: Quieten failed to read counter message
Since 3b3eb0445 running perf stat on a system without
backend-stalled-cycles spits out ugly warnings by default.
Since that is quite common, make the message a debug message only.
We know anyways that the counter wasn't read by the normal <unsupported>
output.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1441147966-14917-1-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index d46dbb1..a96fb5c 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -215,7 +215,7 @@ static void read_counters(bool close_counters)
evlist__for_each(evsel_list, counter) {
if (read_counter(counter))
- pr_warning("failed to read counter %s\n", counter->name);
+ pr_debug("failed to read counter %s\n", counter->name);
if (perf_stat_process_counter(&stat_config, counter))
pr_warning("failed to process counter %s\n", counter->name);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] perf, tools, stat: Quieten failed to read counter message
@ 2015-08-18 23:15 Andi Kleen
0 siblings, 0 replies; 5+ messages in thread
From: Andi Kleen @ 2015-08-18 23:15 UTC (permalink / raw)
To: acme; +Cc: jolsa, linux-kernel, Andi Kleen
From: Andi Kleen <ak@linux.intel.com>
Since 3b3eb0445 running perf stat on a system without
backend-stalled-cycles spits out ugly warnings by default. Since that is quite
common, make the message a debug message only. We know
anyways that the counter wasn't read by the normal <unsupported>
output.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/builtin-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index dd236c8..e76aa6a 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -232,7 +232,7 @@ static void read_counters(bool close_counters)
evlist__for_each(evsel_list, counter) {
if (read_counter(counter))
- pr_warning("failed to read counter %s\n", counter->name);
+ pr_debug("failed to read counter %s\n", counter->name);
if (perf_stat_process_counter(&stat_config, counter))
pr_warning("failed to process counter %s\n", counter->name);
--
2.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-08 14:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-01 22:52 [PATCH] perf, tools, stat: Quieten failed to read counter message Andi Kleen
2015-09-02 6:07 ` Jiri Olsa
2015-09-02 12:53 ` Arnaldo Carvalho de Melo
2015-09-08 14:32 ` [tip:perf/core] perf " tip-bot for Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2015-08-18 23:15 [PATCH] perf, tools, " Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox