From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754436AbbIBNBA (ORCPT ); Wed, 2 Sep 2015 09:01:00 -0400 Received: from mail.kernel.org ([198.145.29.136]:57567 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbbIBNA6 (ORCPT ); Wed, 2 Sep 2015 09:00:58 -0400 Date: Wed, 2 Sep 2015 10:00:53 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Matt Fleming , =?iso-8859-1?Q?Rapha=EBl?= Beamonte , Steven Rostedt Subject: Re: [PATCH 01/15] perf tools: Fix parse_events_add_pmu caller Message-ID: <20150902130053.GE12722@kernel.org> References: <1441180605-24737-1-git-send-email-jolsa@kernel.org> <1441180605-24737-2-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441180605-24737-2-git-send-email-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Sep 02, 2015 at 09:56:31AM +0200, Jiri Olsa escreveu: > Following commit changed parse_events_add_pmu interface: > 36adec85a86f perf tools: Change parse_events_add_pmu interface > > but forgot to change one caller. Because of lessen compilation > rules for the bison parser, the compiler did not warn on that. Humm, wonder what can be done to improve this situation... No ideas? Applying to perf/urgent, Thanks, - Arnaldo > Link: http://lkml.kernel.org/n/tip-fda5a524tfapmpb85bmaigo2@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/parse-events.y | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > index 591905a02b92..9cd70819c795 100644 > --- a/tools/perf/util/parse-events.y > +++ b/tools/perf/util/parse-events.y > @@ -255,7 +255,7 @@ PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF sep_dc > list_add_tail(&term->list, head); > > ALLOC_LIST(list); > - ABORT_ON(parse_events_add_pmu(list, &data->idx, "cpu", head)); > + ABORT_ON(parse_events_add_pmu(data, list, "cpu", head)); > parse_events__free_terms(head); > $$ = list; > } > -- > 2.4.3