From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755141AbbIBOop (ORCPT ); Wed, 2 Sep 2015 10:44:45 -0400 Received: from relay2.sgi.com ([192.48.180.65]:57243 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754855AbbIBOom (ORCPT ); Wed, 2 Sep 2015 10:44:42 -0400 Date: Wed, 2 Sep 2015 09:44:35 -0500 From: Dimitri Sivanich To: Sudip Mukherjee Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] drivers/misc/sgi-gru: make functions static Message-ID: <20150902144435.GB26958@sgi.com> References: <1441193098-13885-1-git-send-email-sudipm.mukherjee@gmail.com> <1441193098-13885-2-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441193098-13885-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Dimitri Sivanich On Wed, Sep 02, 2015 at 04:54:56PM +0530, Sudip Mukherjee wrote: > The functions gru_get_cb_exception_detail_str() and gru_abort() were > only called locally from that file. We can make them static. > > Signed-off-by: Sudip Mukherjee > --- > drivers/misc/sgi-gru/grukservices.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c > index 1f0bdab..a6fd773 100644 > --- a/drivers/misc/sgi-gru/grukservices.c > +++ b/drivers/misc/sgi-gru/grukservices.c > @@ -429,8 +429,8 @@ int gru_get_cb_exception_detail(void *cb, > return 0; > } > > -char *gru_get_cb_exception_detail_str(int ret, void *cb, > - char *buf, int size) > +static char *gru_get_cb_exception_detail_str(int ret, void *cb, > + char *buf, int size) > { > struct gru_control_block_status *gen = (void *)cb; > struct control_block_extended_exc_detail excdet; > @@ -505,7 +505,7 @@ int gru_wait_proc(void *cb) > return ret; > } > > -void gru_abort(int ret, void *cb, char *str) > +static void gru_abort(int ret, void *cb, char *str) > { > char buf[GRU_EXC_STR_SIZE]; > > -- > 1.9.1