From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755194AbbIBOpo (ORCPT ); Wed, 2 Sep 2015 10:45:44 -0400 Received: from relay2.sgi.com ([192.48.180.65]:57280 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755122AbbIBOpn (ORCPT ); Wed, 2 Sep 2015 10:45:43 -0400 Date: Wed, 2 Sep 2015 09:45:35 -0500 From: Dimitri Sivanich To: Sudip Mukherjee Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] drivers/misc/sgi-gru: remove always false condition Message-ID: <20150902144535.GC26958@sgi.com> References: <1441193098-13885-1-git-send-email-sudipm.mukherjee@gmail.com> <1441193098-13885-3-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441193098-13885-3-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Dimitri Sivanich On Wed, Sep 02, 2015 at 04:54:57PM +0530, Sudip Mukherjee wrote: > The member gid in struct gru_dump_chiplet_state_req is unsigned int. So > it can never be less than 0. > > Signed-off-by: Sudip Mukherjee > --- > drivers/misc/sgi-gru/grukdump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c > index fa515e3..dbba197 100644 > --- a/drivers/misc/sgi-gru/grukdump.c > +++ b/drivers/misc/sgi-gru/grukdump.c > @@ -188,7 +188,7 @@ int gru_dump_chiplet_request(unsigned long arg) > return -EFAULT; > > /* Currently, only dump by gid is implemented */ > - if (req.gid >= gru_max_gids || req.gid < 0) > + if (req.gid >= gru_max_gids) > return -EINVAL; > > gru = GID_TO_GRU(req.gid); > -- > 1.9.1