From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932356AbbIBT2j (ORCPT ); Wed, 2 Sep 2015 15:28:39 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:33981 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932280AbbIBT2I (ORCPT ); Wed, 2 Sep 2015 15:28:08 -0400 Date: Wed, 2 Sep 2015 21:29:32 +0200 From: Christoffer Dall To: Eric Auger Cc: eric.auger@st.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, marc.zyngier@arm.com, alex.williamson@redhat.com, feng.wu@intel.com, linux-kernel@vger.kernel.org, patches@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH v3 05/10] VFIO: platform: add vfio_platform_is_active Message-ID: <20150902192932.GT10991@cbox> References: <1439212864-12954-1-git-send-email-eric.auger@linaro.org> <1439212864-12954-6-git-send-email-eric.auger@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439212864-12954-6-git-send-email-eric.auger@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2015 at 03:20:59PM +0200, Eric Auger wrote: > This function returns whether the IRQ is active at irqchip level or > VFIO masked. If either is true, it is considered the IRQ is active. > Currently there is no way to differentiate userspace masked IRQ from > automasked IRQ. There might be false detection of activity. However > it is currently acceptable to have false detection. > > Signed-off-by: Eric Auger > > --- > --- > drivers/vfio/platform/vfio_platform_irq.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c > index a285384..efaee58 100644 > --- a/drivers/vfio/platform/vfio_platform_irq.c > +++ b/drivers/vfio/platform/vfio_platform_irq.c > @@ -205,6 +205,23 @@ static int vfio_platform_set_automasked(struct vfio_platform_irq *irq, > return 0; > } > > +static int vfio_platform_is_active(struct vfio_platform_irq *irq) > +{ > + unsigned long flags; > + bool active, masked, outstanding; > + int ret; > + > + spin_lock_irqsave(&irq->lock, flags); > + > + ret = irq_get_irqchip_state(irq->hwirq, IRQCHIP_STATE_ACTIVE, &active); > + BUG_ON(ret); > + masked = irq->masked; > + outstanding = active || masked; outstanding? why not just return active || masked ? -Christoffer > + > + spin_unlock_irqrestore(&irq->lock, flags); > + return outstanding; > +} > + > static void vfio_platform_irq_bypass_stop(struct irq_bypass_producer *prod) > { > } > -- > 1.9.1 >