From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932268AbbIBTy3 (ORCPT ); Wed, 2 Sep 2015 15:54:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:51494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932144AbbIBTyM (ORCPT ); Wed, 2 Sep 2015 15:54:12 -0400 Date: Wed, 2 Sep 2015 16:54:08 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Andy Lutomirski , Masami Hiramatsu , Denys Vlasenko , Peter Zijlstra , Ingo Molnar , Dave Hansen , Qiaowei Ren , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [PATCH V2 0/7] x86/insn: perf tools: Add a few new x86 instructions Message-ID: <20150902195408.GA11521@kernel.org> References: <1441196131-20632-1-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441196131-20632-1-git-send-email-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Sep 02, 2015 at 03:15:24PM +0300, Adrian Hunter escreveu: > Changes in V2: > > perf tools: Display build warning if x86 instruction decoder differs from kernel > New patch (slightly modified from the proposal and so without Jiri's Ack) Applied. But please consider doing some extra work on at least showing what are the difference. I think those diff calls should be moved to a separate shell script, that would either do what they do now, i.e. show that one line "things changed!" or would produce a diff file that would then have its contents shown, this way one could go on removing such differences, building again, rinse, repeat, till the warning is gone. Thanks a lot! - Arnaldo