From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
peterz@infradead.org, mingo@elte.hu, jolsa@redhat.com,
namhyung@kernel.org, kan.liang@intel.com, dsahern@gmail.com,
adrian.hunter@intel.com
Subject: Re: [PATCH] perf stat: fix per-pkg event reporting bug
Date: Wed, 2 Sep 2015 13:26:57 -0700 [thread overview]
Message-ID: <20150902202657.GC4524@tassilo.jf.intel.com> (raw)
In-Reply-To: <1441199871-7384-1-git-send-email-eranian@google.com>
On Wed, Sep 02, 2015 at 03:17:51PM +0200, Stephane Eranian wrote:
> Per-pkg events need to be captured once per processor
> socket. The code in check_per_pkg() ensures only one
> value per processor package is used. However there is
> a problem with this function in case the first CPU of
> the package does not measure anything for the per-pkg event,
> but other CPUs do.
I've seen a similar(?) bug with -C and --per-core combined.
Some logical threads are not correctly accounted there either.
Do you think that's another instance of such a bug?
-Andi
next prev parent reply other threads:[~2015-09-02 20:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 13:17 [PATCH] perf stat: fix per-pkg event reporting bug Stephane Eranian
2015-09-02 20:26 ` Andi Kleen [this message]
2015-09-03 10:05 ` Jiri Olsa
2015-09-03 10:01 ` Jiri Olsa
2015-09-03 11:48 ` Stephane Eranian
2015-09-03 12:01 ` Jiri Olsa
2015-09-03 12:05 ` Stephane Eranian
2015-09-03 12:13 ` Jiri Olsa
2015-09-03 12:16 ` Stephane Eranian
2015-09-03 12:25 ` Jiri Olsa
2015-09-03 16:53 ` Arnaldo Carvalho de Melo
2015-09-03 17:12 ` Stephane Eranian
2015-09-03 20:42 ` Arnaldo Carvalho de Melo
2015-09-03 21:37 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902202657.GC4524@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox