From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: Warning in irq_work_queue_on()
Date: Thu, 3 Sep 2015 00:24:27 +0200 [thread overview]
Message-ID: <20150902222427.GW19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150902215020.GA21505@lerouge>
On Wed, Sep 02, 2015 at 11:50:22PM +0200, Frederic Weisbecker wrote:
> > > [ 875.703227] [<ffffffff810c2d74>] tick_nohz_full_kick_cpu+0x44/0x50
>
> It happens in nohz full, but I'm not sure the guilty is nohz full.
>
> The problem here is that wake_up_nohz_cpu() selects a CPU that is offline.
wake_up_nohz_cpu() doesn't do any such thing. Where does the selection
logic live?
> But this shouldn't happen. Either it selects a CPU that is in the domain tree,
> and I suspect offline CPUs aren't supposed to be there, or it selects the current
> CPU. And if the CPU is offlined, it shouldn't be running some kthread...
Do no assume things like that.. always check with the active mask.
next prev parent reply other threads:[~2015-09-02 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 0:16 Warning in irq_work_queue_on() Paul E. McKenney
2015-09-02 19:44 ` Tejun Heo
2015-09-02 21:50 ` Frederic Weisbecker
2015-09-02 22:24 ` Peter Zijlstra [this message]
2015-09-03 0:03 ` Frederic Weisbecker
2015-09-03 7:58 ` Peter Zijlstra
2015-09-04 15:11 ` Frederic Weisbecker
2015-09-05 19:53 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902222427.GW19282@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox