public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: lysanovsergey@gmail.com
Cc: forest@alittletooquiet.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging:vt6655: Fix coding style issues
Date: Wed, 2 Sep 2015 18:01:38 -0700	[thread overview]
Message-ID: <20150903010138.GA25982@kroah.com> (raw)
In-Reply-To: <1440759104-20680-1-git-send-email-lysanovsergey@gmail.com>

On Fri, Aug 28, 2015 at 01:51:44PM +0300, lysanovsergey@gmail.com wrote:
> From: Sergey Lysanov <lysanovsergey@gmail.com>
> 
> This patch fixes the following issues reported by checkpatch.pl:
> - code indent should use tabs where possible
> - space prohibited before that ','
> 
> Signed-off-by: Sergey Lysanov <lysanovsergey@gmail.com>
> ---
>  drivers/staging/vt6655/rxtx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 5875d65..64957de 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -64,8 +64,8 @@
>  /*---------------------  Static Functions  --------------------------*/
>  
>  /*---------------------  Static Definitions -------------------------*/
> -#define CRITICAL_PACKET_LEN      256    /* if packet size < 256 -> in-direct send
> -                                            packet size >= 256 -> direct send */
> +#define CRITICAL_PACKET_LEN	256 /* if packet size < 256 -> in-direct send
> +				     packet size >= 256 -> direct send */
>  
>  static const unsigned short wTimeStampOff[2][MAX_RATE] = {
>  	{384, 288, 226, 209, 54, 43, 37, 31, 28, 25, 24, 23}, /* Long Preamble */
> @@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
>  };
>  static const unsigned short wFB_Opt1[2][5] = {
>  	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
> -	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
> +	{RATE_6M, RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */

The goal was to keep these aligned, which you broke the formatting for
:(

      reply	other threads:[~2015-09-03  1:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 10:51 [PATCH] drivers:staging:vt6655: Fix coding style issues lysanovsergey
2015-09-03  1:01 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150903010138.GA25982@kroah.com \
    --to=greg@kroah.com \
    --cc=forest@alittletooquiet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lysanovsergey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox