[PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

[PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

[Anders Fridlund]

Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
with NULL in the assignment.

Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
---
 drivers/staging/most/aim-network/networking.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
index c8ab239..a1e1bce 100644
--- a/drivers/staging/most/aim-network/networking.c
+++ b/drivers/staging/most/aim-network/networking.c
@@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
 
 	unregister_netdev(nd->dev);
 	free_netdev(nd->dev);
-	nd->dev = 0;
+	nd->dev = NULL;
 }
 
 static struct net_dev_context *get_net_dev_context(
-- 
1.9.1

[PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

[Anders Fridlund]

Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
with NULL in the assignment.

Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
---
 drivers/staging/most/aim-network/networking.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
index c8ab239..a1e1bce 100644
--- a/drivers/staging/most/aim-network/networking.c
+++ b/drivers/staging/most/aim-network/networking.c
@@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
 
 	unregister_netdev(nd->dev);
 	free_netdev(nd->dev);
-	nd->dev = 0;
+	nd->dev = NULL;
 }
 
 static struct net_dev_context *get_net_dev_context(
-- 
1.9.1

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

[Greg KH]

On Thu, Aug 20, 2015 at 12:12:51AM +0200, Anders Fridlund wrote:
> Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
> with NULL in the assignment.
> 
> Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
> ---
>  drivers/staging/most/aim-network/networking.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
> index c8ab239..a1e1bce 100644
> --- a/drivers/staging/most/aim-network/networking.c
> +++ b/drivers/staging/most/aim-network/networking.c
> @@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
>  
>  	unregister_netdev(nd->dev);
>  	free_netdev(nd->dev);
> -	nd->dev = 0;
> +	nd->dev = NULL;
>  }
>  
>  static struct net_dev_context *get_net_dev_context(
> -- 
> 1.9.1

Someone sent this patch before you did, sorry :(

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

[Greg KH]

On Sat, Aug 29, 2015 at 01:53:49PM +0200, Anders Fridlund wrote:
> Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
> with NULL in the assignment.
> 
> Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
> ---
>  drivers/staging/most/aim-network/networking.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
> index c8ab239..a1e1bce 100644
> --- a/drivers/staging/most/aim-network/networking.c
> +++ b/drivers/staging/most/aim-network/networking.c
> @@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
>  
>  	unregister_netdev(nd->dev);
>  	free_netdev(nd->dev);
> -	nd->dev = 0;
> +	nd->dev = NULL;
>  }
>  
>  static struct net_dev_context *get_net_dev_context(
> -- 
> 1.9.1

Why did you resend this patch again?

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

[Anders Fridlund]

I resent it since no one responded to it for 10 days. From what I came
to understand that is the common practice. If that is not the case I'm
sorry (and please let me know so I don't do it again).

Cheers,
Anders Fridlund

On Thu, Sep 3, 2015 at 6:41 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Aug 29, 2015 at 01:53:49PM +0200, Anders Fridlund wrote:
>> Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
>> with NULL in the assignment.
>>
>> Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
>> ---
>>  drivers/staging/most/aim-network/networking.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
>> index c8ab239..a1e1bce 100644
>> --- a/drivers/staging/most/aim-network/networking.c
>> +++ b/drivers/staging/most/aim-network/networking.c
>> @@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
>>
>>       unregister_netdev(nd->dev);
>>       free_netdev(nd->dev);
>> -     nd->dev = 0;
>> +     nd->dev = NULL;
>>  }
>>
>>  static struct net_dev_context *get_net_dev_context(
>> --
>> 1.9.1
>
> Why did you resend this patch again?

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

[Greg KH]

On Sat, Sep 05, 2015 at 09:21:58PM +0200, Anders Fridlund wrote:
> I resent it since no one responded to it for 10 days. From what I came
> to understand that is the common practice. If that is not the case I'm
> sorry (and please let me know so I don't do it again).

That's fine to do, but at least say why you are resending it in the area
under the --- line, otherwise we have no idea what is going on.

thanks,

greg k-h

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

[Dan Carpenter]

On Sat, Sep 05, 2015 at 09:21:58PM +0200, Anders Fridlund wrote:
> I resent it since no one responded to it for 10 days. From what I came
> to understand that is the common practice. If that is not the case I'm
> sorry (and please let me know so I don't do it again).
> 

10 days is too short.  Especially since the merge window was open.

regards,
dan carpenter