[PATCH] staging/most: Use NULL instead of plain integer for pointer

[PATCH] staging/most: Use NULL instead of plain integer for pointer

[Rocco Folino]

This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing 0s with NULL.

Signed-off-by: Rocco Folino <rocco@devzen.net>
---
 drivers/staging/most/aim-network/networking.c | 2 +-
 drivers/staging/most/aim-v4l2/video.c         | 2 +-
 drivers/staging/most/hdm-dim2/dim2_hdm.c      | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
index c8ab2399faad..a1e1bce16296 100644
--- a/drivers/staging/most/aim-network/networking.c
+++ b/drivers/staging/most/aim-network/networking.c
@@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
 
 	unregister_netdev(nd->dev);
 	free_netdev(nd->dev);
-	nd->dev = 0;
+	nd->dev = NULL;
 }
 
 static struct net_dev_context *get_net_dev_context(
diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c
index d9687910e4a4..83332454974c 100644
--- a/drivers/staging/most/aim-v4l2/video.c
+++ b/drivers/staging/most/aim-v4l2/video.c
@@ -430,7 +430,7 @@ static struct most_video_dev *get_aim_dev(
 		}
 	}
 	spin_unlock(&list_lock);
-	return 0;
+	return NULL;
 }
 
 static int aim_rx_data(struct mbo *mbo)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c
index 6a5a3a2775f3..e31f1add9663 100644
--- a/drivers/staging/most/hdm-dim2/dim2_hdm.c
+++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c
@@ -248,7 +248,7 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch)
 	unsigned long flags;
 	struct dim_ch_state_t st;
 
-	BUG_ON(hdm_ch == 0);
+	BUG_ON(hdm_ch == NULL);
 	BUG_ON(!hdm_ch->is_initialized);
 
 	spin_lock_irqsave(&dim_lock, flags);
@@ -346,7 +346,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx)
 	unsigned long flags;
 	u8 *data;
 
-	BUG_ON(hdm_ch == 0);
+	BUG_ON(hdm_ch == NULL);
 	BUG_ON(!hdm_ch->is_initialized);
 
 	spin_lock_irqsave(&dim_lock, flags);
@@ -419,7 +419,7 @@ static struct dim_channel **get_active_channels(struct dim2_hdm *dev,
 		if (dev->hch[ch_idx].is_initialized)
 			buffer[idx++] = &dev->hch[ch_idx].ch;
 	}
-	buffer[idx++] = 0;
+	buffer[idx++] = NULL;
 
 	return buffer;
 }
@@ -915,7 +915,7 @@ static int dim2_remove(struct platform_device *pdev)
 	 * break link to local platform_device_id struct
 	 * to prevent crash by unload platform device module
 	 */
-	pdev->id_entry = 0;
+	pdev->id_entry = NULL;
 
 	return 0;
 }
-- 
2.4.3

Re: [PATCH] staging/most: Use NULL instead of plain integer for pointer

[Greg KH]

On Sat, Aug 22, 2015 at 12:41:54AM +0200, Rocco Folino wrote:
> This patch fixes the warning generated by sparse: "Using plain integer
> as NULL pointer" by replacing 0s with NULL.
> 
> Signed-off-by: Rocco Folino <rocco@devzen.net>
> ---
>  drivers/staging/most/aim-network/networking.c | 2 +-
>  drivers/staging/most/aim-v4l2/video.c         | 2 +-
>  drivers/staging/most/hdm-dim2/dim2_hdm.c      | 8 ++++----
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
> index c8ab2399faad..a1e1bce16296 100644
> --- a/drivers/staging/most/aim-network/networking.c
> +++ b/drivers/staging/most/aim-network/networking.c
> @@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
>  
>  	unregister_netdev(nd->dev);
>  	free_netdev(nd->dev);
> -	nd->dev = 0;
> +	nd->dev = NULL;
>  }

Someone sent a patch already that did this change, so this patch doesn't
apply anymore :(